Closed Bug 1445801 Opened 6 years ago Closed 6 years ago

Remove unsafe CPOWs in JSON Viewer tests

Categories

(DevTools :: JSON Viewer, enhancement)

Product:
DevTools
Component:
JSON Viewer
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox61 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: jryans, Assigned: Oriol)

References

Details

Attachments

(1 file)

Bug 1445801 - Remove unsafe CPOWs in JSON Viewer tests
59 bytes, text/x-review-board-request
jryans
: review+
Details 
JSON Viewer tests are using unsafe CPOWs, which should be avoided where possible.

Bug 1445551 will soon add `uses-unsafe-cpows` annotations in test manifests where these are used.  We should aim to get rid of them.
I will take a look.
Assignee: nobody → oriol-bugzilla
Status: NEW → ASSIGNED
Comment on attachment 8959236 [details]
Bug 1445801 - Remove unsafe CPOWs in JSON Viewer tests

https://reviewboard.mozilla.org/r/228110/#review233976

Thanks for working on this!  Assuming try is green, looks good to me! :)
Attachment #8959236 - Flags: review+
Comment on attachment 8959236 [details]
Bug 1445801 - Remove unsafe CPOWs in JSON Viewer tests

I guess your review suffices.
Attachment #8959236 - Flags: review?(odvarko)
Autoland requested, should appear soon.
Keywords: checkin-needed
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/bb2f2b95fff7
Remove unsafe CPOWs in JSON Viewer tests r=jryans
https://hg.mozilla.org/mozilla-central/rev/bb2f2b95fff7
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: