1445989 - ECC SSL tests are skipped after NSS_DISABLE_ECC removal

Status: RESOLVED FIXED

(NSS :: Test, enhancement)

Description

[Daiki Ueno [:ueno]]

Attachment: tests-ssl-ecc-skip.patch

After the removal of NSS_DISABLE_ECC option:
https://hg.mozilla.org/projects/nss/rev/69242366eb810294a1d8e512e60732d832fd3c8a

Some ECC tests in ssl.sh are unconditionally skipped:
$ hg export 69242366eb810294a1d8e512e60732d832fd3c8a | grep -A1 '"\$ectype" = "ECC"'
-      if [ "$ectype" = "ECC" -a -n "$NSS_DISABLE_ECC" ] ; then
+      if [ "$ectype" = "ECC" ] ; then
           echo "$SCRIPTNAME: skipping  $testname (ECC only)"
--
-      elif [ "$ectype" = "ECC" -a  -n "$NSS_DISABLE_ECC" ] ; then
+      elif [ "$ectype" = "ECC" ] ; then
           echo "$SCRIPTNAME: skipping  $testname (ECC only)"
--
-      elif [ "$ectype" = "ECC" -a  -n "$NSS_DISABLE_ECC" ] ; then
+      elif [ "$ectype" = "ECC" -a ] ; then
           echo "$SCRIPTNAME: skipping  $testname (ECC only)"
--
-    if [ "$ectype" = "ECC" -a  -n "$NSS_DISABLE_ECC" ] ; then
+    if [ "$ectype" = "ECC" ] ; then
         echo "$SCRIPTNAME: skipping $testname (ECC only)"
--
-      if [ "$ectype" = "ECC" -a -n "$NSS_DISABLE_ECC" ] ; then
+      if [ "$ectype" = "ECC" ] ; then
           echo "$SCRIPTNAME: skipping  $testname (ECC only)"
--
-      if [ "$ectype" = "ECC" -a  -n "$NSS_DISABLE_ECC" ] ; then
+      if [ "$ectype" = "ECC" ] ; then
         echo "$SCRIPTNAME: skipping  $testname (ECC only)"

I guess "if [ "$ectype" = "ECC" ] ... " statements should be removed altogether.

Comment 1

[Kai Engert (:KaiE:)]

Comment on attachment 8959167 [details] [diff] [review]
tests-ssl-ecc-skip.patch

Yes, I agree. The code previously said "if it's ECC, and the symbol to disable ECC is set (-n means nonempty), then skip it". With the change, the code said "if it's ECC, then skip it", which doesn't make sense.

The changes you have quoted were incorrect. The checks must be removed, because there's no reason to skip the ECC tests, because ECC is always enabled. Thanks for identifying this fix!

r=kaie

Comment 2

[Daiki Ueno [:ueno]]

Landed as: https://hg.mozilla.org/projects/nss/rev/3008d1dbd8fc