1446157 - Remove unused grippy binding

Status: RESOLVED FIXED

(Core :: XUL, task)

Description

[Brian Grinstead [:bgrins]]

This binding isn't used by Firefox: https://dxr.mozilla.org/mozilla-central/search?q=grippy.

Additionally there's CSS in the various splitter.css files and also some image files that should be removable: https://searchfox.org/mozilla-central/search?q=grip-.*%5C.gif&regexp=true&path=.

This binding can be migrated to comm-central if it remains necessary there.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1446157 - Remove unused grippy binding

Review commit: https://reviewboard.mozilla.org/r/229344/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229344/

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1446157 - Follow-up, Remove unused #placesTreechildren style rules

Review commit: https://reviewboard.mozilla.org/r/229346/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229346/

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1446157 - Follow-up, Remove unused grippyhidden="true" attribute from Layout Debugger

Review commit: https://reviewboard.mozilla.org/r/229348/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229348/

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

The commits completely remove the word "grippy" from m-c.

I don't think there is any grippy in Thunderbird, but there are in Sunbird and Seamonkey. Who should we give heads-up to for the later two applications?

Screenshot: https://screenshots.mattn.ca/compare/?oldProject=try&oldRev=ffda3ab9975f01ea4091f769753f96735c75d62f&newProject=try&newRev=cadb1feb29ee16d012d6401e4fcfdb55de0629c5

Comment 5

[Neil Deakin]

There are grippies in the Thunderbird address book at least.

Comment 6

[Brian Grinstead [:bgrins]]

(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #4)
> The commits completely remove the word "grippy" from m-c.
> 
> I don't think there is any grippy in Thunderbird, but there are in Sunbird
> and Seamonkey. Who should we give heads-up to for the later two applications?
> 
> Screenshot:
> https://screenshots.mattn.ca/compare/
> ?oldProject=try&oldRev=ffda3ab9975f01ea4091f769753f96735c75d62f&newProject=tr
> y&newRev=cadb1feb29ee16d012d6401e4fcfdb55de0629c5

(In reply to Neil Deakin from comment #5)
> There are grippies in the Thunderbird address book at least.

The grippy binding can be restored in c-c as has been done with xpfe autocomplete and others.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8960594 [details]
Bug 1446157 - Follow-up, Remove unused grippyhidden="true" attribute from Layout Debugger

https://reviewboard.mozilla.org/r/229348/#review235198

Comment 8

[Drew Willcoxon :adw]

Comment on attachment 8960593 [details]
Bug 1446157 - Follow-up, Remove unused #placesTreechildren style rules

https://reviewboard.mozilla.org/r/229346/#review235308

Nice!

Comment 9

[Neil Deakin]

Comment on attachment 8960592 [details]
Bug 1446157 - Remove unused grippy binding

https://reviewboard.mozilla.org/r/229344/#review235768

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de560a993de1
Remove unused grippy binding r=enndeakin+6102
https://hg.mozilla.org/integration/autoland/rev/be65061c2d72
Follow-up, Remove unused #placesTreechildren style rules r=adw
https://hg.mozilla.org/integration/autoland/rev/2491f8caeffa
Follow-up, Remove unused grippyhidden="true" attribute from Layout Debugger r=dbaron

Comment 11

[Andreea Pavel [:apavel]]

Backed out for failing browser chrome at browser/base/content/test/static/browser_all_files_referenced.js

Push that contains the failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=bf5816cd4b5e3b7a0b5f45bc69fb03ee3cfb7c1f

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=169671575&repo=autoland

Backout: https://hg.mozilla.org/integration/autoland/rev/e1bd2a0806123389100e53c448c1c45cc44fa47b

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8960592 [details]
Bug 1446157 - Remove unused grippy binding

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/229344/diff/1-2/

Comment 14

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8960593 [details]
Bug 1446157 - Follow-up, Remove unused #placesTreechildren style rules

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/229346/diff/1-2/

Comment 15

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8960594 [details]
Bug 1446157 - Follow-up, Remove unused grippyhidden="true" attribute from Layout Debugger

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/229348/diff/1-2/

Comment 16

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Sorry for overlooked that on Try.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c3cc2c68723
Remove unused grippy binding r=enndeakin+6102
https://hg.mozilla.org/integration/autoland/rev/8a9f69a7ea6c
Follow-up, Remove unused #placesTreechildren style rules r=adw
https://hg.mozilla.org/integration/autoland/rev/cbcc7b902237
Follow-up, Remove unused grippyhidden="true" attribute from Layout Debugger r=dbaron

Comment 18

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0c3cc2c68723
https://hg.mozilla.org/mozilla-central/rev/8a9f69a7ea6c
https://hg.mozilla.org/mozilla-central/rev/cbcc7b902237

Comment 19

[Firefox Bug Husbandry Bot]

Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336