1446202 - [geckoview] Klar+GeckoView: fails to display a date picker

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Emily Kager [:ekager]]

https://github.com/mozilla-mobile/focus-android/issues/2226

Possible that GV doesn't support date prompts; versus time+date.

Comment 1

[Chris Peterson [:cpeterson]]

P1 and [geckoview:klar] because it sounds like this would be a UX regression from Klar+WebView.

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

A present for Jim when he returns.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1446202 - 1. Return correct locale string to Gecko;

Locale.toString() doesn't return the correct locale format that Gecko
expects, so reformat the locale string before returning. (for example,
Locale.toString() returns "en_US_POSIX#Latn" whereas Gecko expects
"en-Latn-US-POSIX"). The incorrect locale format was preventing intl
code (and the datetime box) from initializing.

Review commit: https://reviewboard.mozilla.org/r/232834/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232834/

Comment 4

[Dylan Roeh (:droeh) (he/him)]

Comment on attachment 8964024 [details]
Bug 1446202 - 1. Return correct locale string to Gecko;

https://reviewboard.mozilla.org/r/232834/#review238294

LGTM

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/feea08fbd0fc
Return correct locale string to Gecko; r=droeh

Comment 6

[Natalia Csoregi [:nataliaCs]]

Backed out for multiple Android mochitest failures

backout: https://hg.mozilla.org/integration/autoland/rev/b49ab69518f53223b872c0f87ef2fc697eeeaf5e

push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=feea08fbd0fc4c63720dc2b9bf487b45c8b27284&group_state=expanded

try push with the backout: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2154365e114779a33809bfe40a6093b2685b923c&group_state=expanded

Failure logs:
https://treeherder.mozilla.org/logviewer.html#?job_id=171300069&repo=autoland&lineNumber=2097
https://treeherder.mozilla.org/logviewer.html#?job_id=171299919&repo=autoland&lineNumber=1677
https://treeherder.mozilla.org/logviewer.html#?job_id=171303168&repo=autoland&lineNumber=1929
https://treeherder.mozilla.org/logviewer.html#?job_id=171303064&repo=autoland&lineNumber=1648

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1446202 - 2. Don't pass pointer events to datetime inputs;

Like the way we treat select fields, don't pass pointer events to
date/time input fields either.

Review commit: https://reviewboard.mozilla.org/r/233212/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233212/

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8964024 [details]
Bug 1446202 - 1. Return correct locale string to Gecko;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/232834/diff/1-2/

Comment 9

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8964465 [details]
Bug 1446202 - 2. Don't pass pointer events to datetime inputs;

https://reviewboard.mozilla.org/r/233212/#review238666

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae4d46495f5e
1. Return correct locale string to Gecko; r=droeh
https://hg.mozilla.org/integration/autoland/rev/9ca671c7ec5b
2. Don't pass pointer events to datetime inputs; r=jchen

Comment 11

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/ae4d46495f5e
https://hg.mozilla.org/mozilla-central/rev/9ca671c7ec5b