Closed
Bug 1446232
Opened 6 years ago
Closed 6 years ago
Add test of font-family serialization for bug 1434802
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
References
Details
Attachments
(1 file)
No description provided.
| Comment hidden (mozreview-request) |
|
||
Comment 2•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8959399 [details] Bug 1446232 - Add test for font family serialization. https://reviewboard.mozilla.org/r/228222/#review234100 Thanks for writing this, only nits :). r= ::: layout/style/test/test_font_family_serialization.html:4 (Diff revision 1) > +<!DOCTYPE html> > +<meta charset="UTF-8"> > +<link rel="author" title="Xidorn Quan" href="https://www.upsuper.org"> > +<script type="text/javascript" src="/resources/testharness.js"></script> Nit: no need for type=. ::: layout/style/test/test_font_family_serialization.html:9 (Diff revision 1) > +<script type="text/javascript" src="/resources/testharness.js"></script> > +<script type="text/javascript" src="/resources/testharnessreport.js"></script> > +<div id="log"></div> > +<div id="display"></div> > +<script> > +// format: [input, expected serialization] Maybe mention why this isn't a wpt, pointing to aa spec issue to define this?
Attachment #8959399 -
Flags: review?(emilio) → review+
| Comment hidden (mozreview-request) |
Pushed by xquan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c84685d71bcb Add test for font family serialization. r=emilio
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c84685d71bcb
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•