Closed Bug 1446241 Opened 2 years ago Closed 2 years ago

Devedition nightlies happening for each mozilla-release push

Categories

(Release Engineering :: Release Automation: Other, defect)

defect
Not set

Tracking

(firefox59 fixed, firefox60 fixed, firefox61 fixed)

RESOLVED FIXED
Tracking Status
firefox59 --- fixed
firefox60 --- fixed
firefox61 --- fixed

People

(Reporter: nthomas, Assigned: catlee)

Details

(Keywords: leave-open)

Attachments

(1 file)

eg https://treeherder.mozilla.org/#/jobs?repo=mozilla-release&revision=3db9e3d52b17563efca181ccbb50deb8660c59ae&filter-searchStr=devedition

There's a nightly, symbol upload, and upload generated sources for each of the five main platforms.
Assignee: nobody → catlee
Comment on attachment 8960286 [details]
Bug 1446241: Set run-on-projects for upload-generated-sources and upload-symbols

https://reviewboard.mozilla.org/r/229056/#review234812

::: taskcluster/taskgraph/transforms/task.py:1636
(Diff revision 1)
>  
>          attributes = task.get('attributes', {})
> +        # Resolve run-on-projects
> +        build_platform = attributes.get('build_platform')
> +        resolve_keyed_by(task, 'run-on-projects', item_name=task['label'],
> +                         **{'build-platform': build_platform})

Any reason you're doing `**{key: val}` rather than `key=val` ?
Attachment #8960286 - Flags: review?(aki) → review+
Comment on attachment 8960286 [details]
Bug 1446241: Set run-on-projects for upload-generated-sources and upload-symbols

https://reviewboard.mozilla.org/r/229056/#review234812

> Any reason you're doing `**{key: val}` rather than `key=val` ?

build-platform is not a valid python identifier.
Keywords: leave-open
Pushed by catlee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2de4efc4f714
Set run-on-projects for upload-generated-sources and upload-symbols r=aki
Comment on attachment 8960286 [details]
Bug 1446241: Set run-on-projects for upload-generated-sources and upload-symbols

Approval Request Comment
[Feature/Bug causing the regression]: 
[User impact if declined]: confusingly producing devedition builds on m-r
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: easy to verify after uplift
[String changes made/needed]: n/a
Attachment #8960286 - Flags: approval-mozilla-release?
Attachment #8960286 - Flags: approval-mozilla-beta?
Comment on attachment 8960286 [details]
Bug 1446241: Set run-on-projects for upload-generated-sources and upload-symbols

Nice, I'd been wondering about this myself.
Attachment #8960286 - Flags: approval-mozilla-release?
Attachment #8960286 - Flags: approval-mozilla-release+
Attachment #8960286 - Flags: approval-mozilla-beta?
Attachment #8960286 - Flags: approval-mozilla-beta+
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.