1446241 - Devedition nightlies happening for each mozilla-release push

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

eg https://treeherder.mozilla.org/#/jobs?repo=mozilla-release&revision=3db9e3d52b17563efca181ccbb50deb8660c59ae&filter-searchStr=devedition

There's a nightly, symbol upload, and upload generated sources for each of the five main platforms.

Comment 1

[Chris AtLee [:catlee]]

Attachment: Bug 1446241: Set run-on-projects for upload-generated-sources and upload-symbols

If tasks still exist before the optimization phase, then any tasks these depend
on will also be scheduled. In particular for devedition on m-r, that means that
although the builds were being excluded from the target tasks due to the
build's run-on-projects settings, the upload-symbols and
upload-generated-sources tasks did exist in the target tasks, and so the builds
got re-added to the target tasks during graph optimization.

Review commit: https://reviewboard.mozilla.org/r/229056/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229056/

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 8960286 [details]
Bug 1446241: Set run-on-projects for upload-generated-sources and upload-symbols

https://reviewboard.mozilla.org/r/229056/#review234812

::: taskcluster/taskgraph/transforms/task.py:1636
(Diff revision 1)
>  
>          attributes = task.get('attributes', {})
> +        # Resolve run-on-projects
> +        build_platform = attributes.get('build_platform')
> +        resolve_keyed_by(task, 'run-on-projects', item_name=task['label'],
> +                         **{'build-platform': build_platform})

Any reason you're doing `**{key: val}` rather than `key=val` ?

Comment 3

[Chris AtLee [:catlee]]

Comment on attachment 8960286 [details]
Bug 1446241: Set run-on-projects for upload-generated-sources and upload-symbols

https://reviewboard.mozilla.org/r/229056/#review234812

> Any reason you're doing `**{key: val}` rather than `key=val` ?

build-platform is not a valid python identifier.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2de4efc4f714
Set run-on-projects for upload-generated-sources and upload-symbols r=aki

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/2de4efc4f714

Comment 6

[Chris AtLee [:catlee]]

Comment on attachment 8960286 [details]
Bug 1446241: Set run-on-projects for upload-generated-sources and upload-symbols

Approval Request Comment
[Feature/Bug causing the regression]: 
[User impact if declined]: confusingly producing devedition builds on m-r
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: easy to verify after uplift
[String changes made/needed]: n/a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8960286 [details]
Bug 1446241: Set run-on-projects for upload-generated-sources and upload-symbols

Nice, I'd been wondering about this myself.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f38f39a9cd54

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/d4ec1d228339