1446253 - Make EventUtils.synthesizeComposition() dispatch keydown event which is marked as "processed by IME" in default

Status: RESOLVED FIXED

(Core :: DOM: Events, enhancement, P2)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

We'll start to dispatch "keydown" and "keyup" events during composition. So, when mochitests emulates composition, "keydown" and "keyup" events should be synthesized for checking actual behavior. On the other hand, composition events may be fired without keydown and keyup events if it's caused without keyboard such as voice input or hand writing. So, we still need to provide a way to synthesize composition events without keyboard events though.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e73970756b72b2727da3630709b6a449acda62f1

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e232270d95dd02de3e4928e66881c6d0217aa9fa

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=96433662592460798c7fead82423acecb3a18566

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1446253 - Make EventUtils.synthesizeComposition() dispatch keydown and keyup event in default

We'll start to dispatch keydown event and keyup event even during composition.
So, for testing those events won't break our UI, we should make
EventUtils.synhtesizeComposition() and EventUtils.synthesizeCompositionChange()
dispatch keydown event and keyup event even if callers don't specify keyboard
event explicitly.

Typically, "keydown" event is marked as "processed by IME", i.e., keyCode
value is set to DOM_VK_PROCESSKEY and key is set to "Process", with our
widget which handles native IME and key input.  On the other hand, "keyup"
is NOT marked as so.

Therefore, this patch makes TextInputProcessor emulates this behavior without
any new special flags.  And for making possible to emulate special cases,
this patch adds two flags to nsITextInputProcessor.  One is
KEY_DONT_MARK_KEYDOWN_AS_PROCESSED.  The other is KEY_MARK_KEYUP_AS_PROCESSED.
Unfortunately, those flags have opposite meaning but this must be better than
making necessary to one flag for emulating usual keydown/keyup events.

Finally, this makes some tests specify better keyboard information to
synthesizeComposition() and synthesizeCompositionChange() to emulate
actual keyboard events during composition.

Review commit: https://reviewboard.mozilla.org/r/228594/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228594/

Comment 5

[Olli Pettay [:smaug]]

Comment on attachment 8959747 [details]
Bug 1446253 - Make EventUtils.synthesizeComposition() dispatch keydown and keyup event in default

https://reviewboard.mozilla.org/r/228594/#review234438

The flags are a bit confusing, but I don't have better ideas.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f035cfad6ac4
Make EventUtils.synthesizeComposition() dispatch keydown and keyup event in default r=smaug

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/f035cfad6ac4