1446270 - Android/arm target should turn on crash reporter as default

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Makoto Kato [:m_kato]]

You know, android/arm's target value is arm-unknown-linux-androideabi, But https://searchfox.org/mozilla-central/rev/6e96a3f1e44e286ddae5fdafab737709741d237a/old-configure.in#2834 matches as android/arm target, so MOZ_CRASHREPORTER is alway unset for Android/arm.

Comment 1

[Makoto Kato [:m_kato]]

automation adds --enable-crashreporter, so MOZ_CRASHREPORTER is set.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1446270 - Android/arm target should turn on crash reporter as default.

target value of Anndroid/arm is arm-unknown-linux-androideabi, so arm-*-linux*
matches on android/arm and MOZ_CRASHREPORTER is unset as default option.

Since taskcluster's build adds --enable-crashrepoter as default, we should set
it as developer's default too.

Review commit: https://reviewboard.mozilla.org/r/228262/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228262/

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8959451 [details]
Bug 1446270 - Android/arm target should turn on crash reporter as default.

https://reviewboard.mozilla.org/r/228262/#review234166

Does this mean we haven't been getting crashreports from Android for...a long time?  Or just that it hasn't been the default for the build?

::: old-configure.in:2834
(Diff revision 1)
> +*-android*|*-linuxandroid*)
> +  MOZ_CRASHREPORTER=1
> +  ;;

Might be worth a comment here indicating that this needs to come before the linux case?  Ideally this code will go away soon, so perhaps it doesn't matter much.

Comment 4

[Nick Alexander :nalexander [he/him]]

(In reply to Nathan Froyd [:froydnj] from comment #3)
> Comment on attachment 8959451 [details]
> Bug 1446270 - Android/arm target should turn on crash reporter as default.
> 
> https://reviewboard.mozilla.org/r/228262/#review234166
> 
> Does this mean we haven't been getting crashreports from Android for...a
> long time?  Or just that it hasn't been the default for the build?

We definitely have been getting Android crash reports, but it's probably not been the default for the build.

> ::: old-configure.in:2834
> (Diff revision 1)
> > +*-android*|*-linuxandroid*)
> > +  MOZ_CRASHREPORTER=1
> > +  ;;
> 
> Might be worth a comment here indicating that this needs to come before the
> linux case?  Ideally this code will go away soon, so perhaps it doesn't
> matter much.

Let us hope :)

Comment 5

[(not currently active) Ted Mielczarek]

Someone should move this all to moz.configure at some point.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf807404eb88
Android/arm target should turn on crash reporter as default. r=froydnj

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/bf807404eb88