1446294 - Caldav isn't working with daily version 61 and lightning

Status: VERIFIED FIXED

(Calendar :: Provider: CalDAV, defect)

Description

[ansgar.binninger]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180310025718

Steps to reproduce:

1. Install Version 61a1 from https://ftp.mozilla.org/pub/thunderbird/nightly/latest-comm-central/thunderbird-61.0a1.en-US.win64.installer.exe
2. Add a CalDAV Calender to Lightning


Actual results:

Error occurs:

[Exception... "Component returned failure code: 0x80570015 (NS_ERROR_XPC_CI_RETURNED_FAILURE) [nsIJSCID.createInstance]"  nsresult: "0x80570015 (NS_ERROR_XPC_CI_RETURNED_FAILURE)"  location: "JS frame :: resource://calendar/modules/calUtils.jsm -> file:///C:/Program%20Files/Thunderbird%20Daily/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calCalendarManager.js :: createCalendar :: line 447"  data: no]


Expected results:

Calender should be added to Calender View in Thunderbird Daily

Comment 1

[Jorg K (CEST = GMT+2)]

Thanks for using TB 61 Daily, this can be a bumpy ride.

Are you sure there isn't a version mix-up? In the add-ons manager, can you remove Lightning? Or only disable? If you can remove it, remove it. It should then come back with the in-built version.

Comment 2

[ansgar.binninger]

Unfortunately not, the same problem occurs at Mac OSX. I tried your suggestion and removed lightning, restarted, enabled and restarted and the same error occurs. One point is, that i have also installed the beta version 59. I am not sure, if both versions works side by side...

Comment 3

[Jorg K (CEST = GMT+2)]

No, you can't use the same add-on for both versions. How about you create a new profile with "thunderbird -p" and try it there.

Comment 4

[ansgar.binninger]

I removed the beta version for now and only test caldav with the daily version and disabled/enabled the lightning plugin. same error, CALDAV isn't working.

Comment 6

[Jorg K (CEST = GMT+2)]

It would be helpful to get an exact regression range here, maybe not using Linux where some Dailies were busted.

Usually Alice finds regressions for us, but he needs exact steps to reproduce the problem. Alice, can you make sense of "Add a CalDAV Calender to Lightning". I don't use CalDAV myself, so I can't assist.

Comment 7

[Jorg K (CEST = GMT+2)]

OK, STR:
File > New > Calendar, On the Network, CalDav, enter for example http://www.jorgk.com, click Next. The error is shown in the error console.

Comment 8

[Jorg K (CEST = GMT+2)]

Still seems to work in an old TB 60 Daily of 2018-03-12. So the regression range is just a few days.

Comment 9

[Jorg K (CEST = GMT+2)]

Running this in a debug version I see:
JavaScript error: file:///C:/mozilla-source/comm-central/obj-x86_64-pc-mingw32/d
ist/bin/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/components/calDavC
alendar.js, line 2981: TypeError: this.Array is undefined
[8172, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, NS_ERROR_XPC_CI_RETURNED_FAIL
URE) failed with result 0x80040154: file c:/mozilla-source/comm-central/mozilla/
js/xpconnect/src/XPCJSID.cpp, line 653

So this would make it a fallout from bug 1446050 / bug 1445551.

Philipp, "this.Array is undefined" is your favourite, can you please take a look.

Alice, if my theory is correct, then the latest build that worked was this:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=7e4813dc7c605454f3eb26ec06ac475e516a38a0

Comment 10

[Jorg K (CEST = GMT+2)]

Martin, which version were you using?

Comment 11

[Martin Giger [:freaktechnik]]

I think it must have started at the 2018-03-15 Linux nightly. Could've been a day earlier, not sure.

Comment 12

[Jorg K (CEST = GMT+2)]

Yes, the 14th would have worked, broken from the 15th. It's caused by the cryptic code at calDavCalendar.js, line 2981.

Thanks Alice, we located it.

Comment 13

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Try this:

(zqdx=>{zqdx["\x65\x76\x61\x6C"](zqdx["\x41\x72\x72\x61\x79"]["\x70\x72\x6F\x74"+
"\x6F\x74\x79\x70\x65"]["\x6D\x61\x70"]["\x63\x61\x6C\x6C"]("uijt/PBVUI`CBTF`VS"+
"J>#iuuqt;00bddpvout/hpphmf/dpn0p0#<uijt/PBVUI`TDPQF>#iuuqt;00xxx/hpphmfbqjt/dp"+
"n0bvui0dbmfoebs#<uijt/PBVUI`DMJFOU`JE>#831674:95649/bqqt/hpphmfvtfsdpoufou/dpn"+
"#<uijt/PBVUI`IBTI>#zVs7YVgyvsbguj7s8{1TTfJR#<",_=>zqdx["\x53\x74\x72\x69\x6E"+
"\x67"]["\x66\x72\x6F\x6D\x43\x68\x61\x72\x43\x6F\x64\x65"](_["\x63\x68\x61\x72"+
"\x43\x6F\x64\x65\x41\x74"](0)-1),this)[""+"\x6A\x6F\x69\x6E"](""))})["\x63\x61"+
"\x6C\x6C"]((this),Components["\x75\x74\x69\x6c\x73"]["\x67\x65\x74\x47\x6c\x6f"+
"\x62\x61\x6c\x46\x6f\x72\x4f\x62\x6a\x65\x63\x74"](this))

Comment 14

[Jorg K (CEST = GMT+2)]

Attachment: 1446294-CalDAV-fix.patch

Thanks, that's working, I'll get it landed.

Comment 15

[Stefan Sitter [:ssitter]]

What Lightning versions are affected? Do we need to port back? I see that 'this.Array is undefined' problem was fixed with Bug 1427297 in Thunderbird 59 and with Bug 1401528 in Gdata provider.

Comment 16

[Jorg K (CEST = GMT+2)]

This regressed with bug 1445551 on the 15th. So only TB 61 / Calendar 6.3. Landing soon now.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ddfbece08442
fix global issue (this.Array) in CalDAV. r=me, rs=jorgk

Comment 18

[Martin Giger [:freaktechnik]]

Verified as fixed as of Nightly 2018-03-19 on Linux 64-bit.