Closed Bug 1446304 Opened 6 years ago Closed 5 years ago

Intermittent E TEST-UNEXPECTED-TIMEOUT | test_tasks_skip.js | Test timed out

Categories

(Testing :: XPCShell Harness, defect, P5)

Version 3
defect

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1517686

People

(Reporter: intermittent-bug-filer, Assigned: gbrown)

References

Details

(Keywords: intermittent-failure)

Filed by: ncsoregi [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=168418001&repo=autoland

https://queue.taskcluster.net/v1/task/dJ_wPSwTTSeGA9jTMc8vIg/runs/0/artifacts/public/logs/live_backing.log

8:11:01     INFO - ================================== FAILURES ===================================
08:11:01     INFO - _____________________ XPCShellTestsTests.testAddTaskSkip ______________________
08:11:01     INFO - self = <selftest.XPCShellTestsTests testMethod=testAddTaskSkip>
08:11:01     INFO -     def testAddTaskSkip(self):
08:11:01     INFO -         self.writeFile("test_tasks_skip.js", ADD_TASK_SKIP)
08:11:01     INFO -         self.writeManifest(["test_tasks_skip.js"])
08:11:01     INFO - >       self.assertTestResult(True)
08:11:01     INFO - ..\testing\xpcshell\selftest.py:1068:
08:11:01     INFO - _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
08:11:01     INFO - ..\testing\xpcshell\selftest.py:527: in assertTestResult
08:11:01     INFO -     """ % ("passed" if expected else "failed", self.log.getvalue()))
08:11:01     INFO - E   AssertionError: Tests should have passed, log:
08:11:01     INFO - E   ========
08:11:01     INFO - E   MOZ_NODE_PATH environment variable not set. Tests requiring http/2 will fail.
08:11:01     INFO - E   Running tests sequentially.
08:11:01     INFO - E   SUITE-START | Running 1 tests
08:11:01     INFO - E   TEST-START | test_tasks_skip.js
08:11:01  WARNING - E   TEST-UNEXPECTED-TIMEOUT | test_tasks_skip.js | Test timed out
08:11:01     INFO - E   TEST-INFO took 15001ms
08:11:01     INFO - E   >>>>>>>
08:11:01     INFO - E   (xpcshell/head.js) | test MAIN run_test pending (1)
08:11:01     INFO - E   (xpcshell/head.js) | test run_next_test 0 pending (2)
08:11:01     INFO - E   (xpcshell/head.js) | test MAIN run_test finished (2)
08:11:01     INFO - E   running event loop
08:11:01     INFO - E   test_tasks_skip.js | Starting skipMeNot1
08:11:01     INFO - E   (xpcshell/head.js) | test skipMeNot1 pending (2)
08:11:01     INFO - E   TEST-PASS | test_tasks_skip.js | skipMeNot1 - [skipMeNot1 : 3] Well well well. - true == true
08:11:01     INFO - E   (xpcshell/head.js) | test run_next_test 0 finished (2)
08:11:01     INFO - E   (xpcshell/head.js) | test run_next_test 1 pending (2)
08:11:01     INFO - E   (xpcshell/head.js) | test skipMeNot1 finished (2)
08:11:01     INFO - E   test_tasks_skip.js | Starting skipMe1
08:11:01     INFO - E   (xpcshell/head.js) | test skipMe1 pending (2)
08:11:01     INFO - E   TEST-SKIP | test_tasks_skip.js | skipMe1 - skipMe1 skipped because the following conditions were met: (explicitly skipped.)
08:11:01     INFO - E   (xpcshell/head.js) | test run_next_test pending (3)
08:11:01     INFO - E   (xpcshell/head.js) | test run_next_test 1 finished (3)
08:11:01     INFO - E   (xpcshell/head.js) | test run_next_test 2 pending (3)
08:11:01     INFO - E   (xpcshell/head.js) | test skipMe1 finished (3)
08:11:01     INFO - E   (xpcshell/head.js) | test run_next_test finished (2)
08:11:01     INFO - E   test_tasks_skip.js | Starting skipMeNot2
08:11:01     INFO - E   (xpcshell/head.js) | test skipMeNot2 pending (2)
08:11:01     INFO - E   TEST-PASS | test_tasks_skip.js | skipMeNot2 - [skipMeNot2 : 11] Well well well. - true == true
08:11:01     INFO - E   (xpcshell/head.js) | test run_next_test 2 finished (2)
08:11:01     INFO - E   (xpcshell/head.js) | test run_next_test 3 pending (2)
08:11:01     INFO - E   (xpcshell/head.js) | test skipMeNot2 finished (2)
08:11:01     INFO - E   test_tasks_skip.js | Starting skipMeNot3
08:11:01     INFO - E   (xpcshell/head.js) | test skipMeNot3 pending (2)
08:11:01     INFO - E   TEST-PASS | test_tasks_skip.js | skipMeNot3 - [skipMeNot3 : 15] Well well well. - true == true
08:11:01     INFO - E   (xpcshell/head.js) | test run_next_test 3 finished (2)
08:11:01     INFO - E   (xpcshell/head.js) | test run_next_test 4 pending (2)
08:11:01     INFO - E   (xpcshell/head.js) | test skipMeNot3 finished (2)
08:11:01     INFO - E   test_tasks_skip.js | Starting skipMe2
08:11:01     INFO - E   (xpcshell/head.js) | test skipMe2 pending (2)
08:11:01     INFO - E   TEST-SKIP | test_tasks_skip.js | skipMe2 - skipMe2 skipped because the following conditions were met: (explicitly skipped.)
08:11:01     INFO - E   (xpcshell/head.js) | test run_next_test pending (3)
08:11:01     INFO - E   (xpcshell/head.js) | test run_next_test 4 finished (3)
08:11:01     INFO - E   (xpcshell/head.js) | test run_next_test 5 pending (3)
08:11:01     INFO - E   (xpcshell/head.js) | test skipMe2 finished (3)
08:11:01     INFO - E   (xpcshell/head.js) | test run_next_test finished (2)
08:11:01     INFO - E   (xpcshell/head.js) | test run_next_test 5 finished (1)
08:11:01     INFO - E   exiting test
08:11:01     INFO - E   <<<<<<<
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INCOMPLETE
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → INCOMPLETE
https://treeherder.mozilla.org/logviewer.html#?job_id=189700438&repo=autoland&lineNumber=67464

05:16:29     INFO - z:\build\build\src\tools\lint\test\test_flake8.py
05:16:29     INFO - ============================= test session starts =============================
05:16:29     INFO - platform win32 -- Python 2.7.14, pytest-3.6.2, py-1.5.4, pluggy-0.6.0 -- z:\build\build\src\obj-firefox\_virtualenvs\src-5kxztrTV-2.7\Scripts\python.exe
05:16:29     INFO - rootdir: z:\build\build\src, inifile: z:\build\build\src\config\mozunit\mozunit\pytest.ini
05:16:29     INFO - collecting ... collected 7 items
05:16:29     INFO - ..\tools\lint\test\test_flake8.py::test_lint_single_file PASSED
05:16:29     INFO - ..\tools\lint\test\test_flake8.py::test_lint_custom_config PASSED
05:16:29     INFO - ..\tools\lint\test\test_flake8.py::test_lint_fix PASSED
05:16:29     INFO - ..\tools\lint\test\test_flake8.py::test_lint_fix_uses_config PASSED
05:16:29     INFO - ..\tools\lint\test\test_flake8.py::test_lint_custom_config_from_parent_path xfail
05:16:29     INFO - ..\tools\lint\test\test_flake8.py::test_lint_excluded_file xfail
05:16:29     INFO - ..\tools\lint\test\test_flake8.py::test_lint_uses_custom_extensions PASSED
05:16:29     INFO - ==================== 5 passed, 2 xfailed in 31.61 seconds =====================
05:16:34     INFO - z:\build\build\src\testing\mozbase\mozprocess\tests\test_wait.py
05:16:34     INFO - ============================= test session starts =============================
05:16:34     INFO - platform win32 -- Python 2.7.14, pytest-3.6.2, py-1.5.4, pluggy-0.6.0 -- z:\build\build\src\obj-firefox\_virtualenvs\src-5kxztrTV-2.7\Scripts\python.exe
05:16:34     INFO - rootdir: z:\build\build\src, inifile: z:\build\build\src\config\mozunit\mozunit\pytest.ini
05:16:34     INFO - collecting ... collected 6 items
05:16:34     INFO - ..\testing\mozbase\mozprocess\tests\test_wait.py::ProcTestWait::test_normal_finish PASSED
05:16:34     INFO - ..\testing\mozbase\mozprocess\tests\test_wait.py::ProcTestWait::test_timeout PASSED
05:16:34     INFO - ..\testing\mozbase\mozprocess\tests\test_wait.py::ProcTestWait::test_wait PASSED
05:16:34     INFO - ..\testing\mozbase\mozprocess\tests\test_wait.py::ProcTestWait::test_wait_twice_after_kill PASSED
05:16:34     INFO - ..\testing\mozbase\mozprocess\tests\test_wait.py::ProcTestWait::test_waitnotimeout PASSED
05:16:34     INFO - ..\testing\mozbase\mozprocess\tests\test_wait.py::ProcTestWait::test_waittimeout PASSED
05:16:34     INFO - ========================== 6 passed in 56.12 seconds ==========================
05:16:34     INFO - z:\build\build\src\config\tests\test_mozbuild_reading.py
05:16:34     INFO - ============================= test session starts =============================
05:16:34     INFO - platform win32 -- Python 2.7.14, pytest-3.6.2, py-1.5.4, pluggy-0.6.0 -- z:\build\build\src\obj-firefox\_virtualenvs\src-5kxztrTV-2.7\Scripts\python.exe
05:16:34     INFO - rootdir: z:\build\build\src, inifile: z:\build\build\src\config\mozunit\mozunit\pytest.ini
05:16:34     INFO - collecting ... collected 3 items
05:16:34     INFO - ..\config\tests\test_mozbuild_reading.py::TestMozbuildReading::test_filesystem_traversal_no_config PASSED
05:16:34     INFO - ..\config\tests\test_mozbuild_reading.py::TestMozbuildReading::test_filesystem_traversal_reading <- c:\mozilla-build\python\Lib\unittest\case.py SKIPPED
05:16:34     INFO - ..\config\tests\test_mozbuild_reading.py::TestMozbuildReading::test_orphan_file_patterns SKIPPED
05:16:34     INFO - ==================== 1 passed, 2 skipped in 185.79 seconds ====================
05:16:34     INFO - z:\build\build\src\config\tests\unit-printprereleasesuffix.py
05:16:34     INFO - ============================= test session starts =============================
05:16:34     INFO - platform win32 -- Python 2.7.14, pytest-3.6.2, py-1.5.4, pluggy-0.6.0 -- z:\build\build\src\obj-firefox\_virtualenvs\src-5kxztrTV-2.7\Scripts\python.exe
05:16:34     INFO - rootdir: z:\build\build\src, inifile: z:\build\build\src\config\mozunit\mozunit\pytest.ini
05:16:34     INFO - collecting ... collected 13 items
05:16:34     INFO - ..\config\tests\unit-printprereleasesuffix.py::TestGetPreReleaseSuffix::test_a_a PASSED
05:16:34     INFO - ..\config\tests\unit-printprereleasesuffix.py::TestGetPreReleaseSuffix::test_a_b PASSED
05:16:34     INFO - ..\config\tests\unit-printprereleasesuffix.py::TestGetPreReleaseSuffix::test_alpha_1 PASSED
05:16:34     INFO - ..\config\tests\unit-printprereleasesuffix.py::TestGetPreReleaseSuffix::test_alpha_10 PASSED
05:16:34     INFO - ..\config\tests\unit-printprereleasesuffix.py::TestGetPreReleaseSuffix::test_alpha_1_pre PASSED
05:16:34     INFO - ..\config\tests\unit-printprereleasesuffix.py::TestGetPreReleaseSuffix::test_b_b PASSED
05:16:34     INFO - ..\config\tests\unit-printprereleasesuffix.py::TestGetPreReleaseSuffix::test_beta_10_pre PASSED
05:16:34     INFO - ..\config\tests\unit-printprereleasesuffix.py::TestGetPreReleaseSuffix::test_beta_3 PASSED
05:16:34     INFO - ..\config\tests\unit-printprereleasesuffix.py::TestGetPreReleaseSuffix::test_beta_30 PASSED
05:16:34     INFO - ..\config\tests\unit-printprereleasesuffix.py::TestGetPreReleaseSuffix::test_plus PASSED
05:16:34     INFO - ..\config\tests\unit-printprereleasesuffix.py::TestGetPreReleaseSuffix::test_pre_0 PASSED
05:16:34     INFO - ..\config\tests\unit-printprereleasesuffix.py::TestGetPreReleaseSuffix::test_pre_1_b PASSED
05:16:34     INFO - ..\config\tests\unit-printprereleasesuffix.py::TestGetPreReleaseSuffix::test_release_1 PASSED
05:16:34     INFO - ========================== 13 passed in 0.03 seconds ==========================
05:16:34     INFO - z:\build\build\src\config\tests\unit-mozunit.py
05:16:34     INFO - ============================= test session starts =============================
05:16:34     INFO - platform win32 -- Python 2.7.14, pytest-3.6.2, py-1.5.4, pluggy-0.6.0 -- z:\build\build\src\obj-firefox\_virtualenvs\src-5kxztrTV-2.7\Scripts\python.exe
05:16:34     INFO - rootdir: z:\build\build\src, inifile: z:\build\build\src\config\mozunit\mozunit\pytest.ini
05:16:34     INFO - collecting ... collected 1 item
05:16:34     INFO - ..\config\tests\unit-mozunit.py::TestMozUnit::test_mocked_open PASSED
05:16:34     INFO - ========================== 1 passed in 0.02 seconds ===========================
05:16:34     INFO - z:\build\build\src\config\tests\unit-nsinstall.py
05:16:34     INFO - ============================= test session starts =============================
05:16:34     INFO - platform win32 -- Python 2.7.14, pytest-3.6.2, py-1.5.4, pluggy-0.6.0 -- z:\build\build\src\obj-firefox\_virtualenvs\src-5kxztrTV-2.7\Scripts\python.exe
05:16:34     INFO - rootdir: z:\build\build\src, inifile: z:\build\build\src\config\mozunit\mozunit\pytest.ini
05:16:34     INFO - collecting ... collected 9 items
05:16:34     INFO - ..\config\tests\unit-nsinstall.py::TestNsinstall::test_nsinstall_D PASSED
05:16:34     INFO - ..\config\tests\unit-nsinstall.py::TestNsinstall::test_nsinstall_basic PASSED
05:16:34     INFO - ..\config\tests\unit-nsinstall.py::TestNsinstall::test_nsinstall_basic_recursive PASSED
05:16:34     INFO - ..\config\tests\unit-nsinstall.py::TestNsinstall::test_nsinstall_d PASSED
05:16:34     INFO - ..\config\tests\unit-nsinstall.py::TestNsinstall::test_nsinstall_dir_exists PASSED
05:16:34     INFO - ..\config\tests\unit-nsinstall.py::TestNsinstall::test_nsinstall_multiple PASSED
05:16:34     INFO - ..\config\tests\unit-nsinstall.py::TestNsinstall::test_nsinstall_non_ascii PASSED
05:16:34     INFO - ..\config\tests\unit-nsinstall.py::TestNsinstall::test_nsinstall_non_ascii_subprocess PASSED
05:16:34     INFO - ..\config\tests\unit-nsinstall.py::TestNsinstall::test_nsinstall_t PASSED
05:16:34     INFO - ========================== 9 passed in 0.83 seconds ===========================
05:16:34     INFO - z:\build\build\src\build\compare-mozconfig\compare-mozconfigs.py
05:16:34     INFO - ============================= test session starts =============================
05:16:34     INFO - platform win32 -- Python 2.7.14, pytest-3.6.2, py-1.5.4, pluggy-0.6.0 -- z:\build\build\src\obj-firefox\_virtualenvs\src-5kxztrTV-2.7\Scripts\python.exe
05:16:34     INFO - rootdir: z:\build\build\src, inifile: z:\build\build\src\config\mozunit\mozunit\pytest.ini
05:16:34     INFO - collecting ... collected 1 item
05:16:34     INFO - ..\build\compare-mozconfig\compare-mozconfigs.py::TestCompareMozconfigs::test_compare_mozconfigs PASSED
05:16:34     INFO - ========================== 1 passed in 0.09 seconds ===========================
05:17:31     INFO - z:\build\build\src\testing\xpcshell\selftest.py
05:17:31     INFO - ============================= test session starts =============================
05:17:31     INFO - platform win32 -- Python 2.7.14, pytest-3.6.2, py-1.5.4, pluggy-0.6.0 -- z:\build\build\src\obj-firefox\_virtualenvs\src-5kxztrTV-2.7\Scripts\python.exe
05:17:31     INFO - rootdir: z:\build\build\src, inifile: z:\build\build\src\config\mozunit\mozunit\pytest.ini
05:17:31     INFO - collecting ... collected 55 items
05:17:31     INFO - ..\testing\xpcshell\selftest.py::XPCShellTestsTests::testAddTaskRunNextTest PASSED
05:17:31  WARNING - ..\testing\xpcshell\selftest.py::XPCShellTestsTests::testAddTaskSkip TEST-UNEXPECTED-FAIL
05:17:31     INFO - ..\testing\xpcshell\selftest.py::XPCShellTestsTests::testAddTaskSkipAll PASSED
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → INCOMPLETE
Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=202855433&repo=autoland&lineNumber=47050
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Status: REOPENED → RESOLVED
Closed: 6 years ago5 years ago
Resolution: --- → INCOMPLETE

Recent failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=265080858&repo=autoland&lineNumber=47779

task 2019-09-05T06:46:42.369Z] 06:46:42 INFO - check> ================================== FAILURES ===================================
[task 2019-09-05T06:46:42.369Z] 06:46:42 INFO - check> _____________________ XPCShellTestsTests.testAddTaskSkip ______________________
[task 2019-09-05T06:46:42.369Z] 06:46:42 INFO - check>
[task 2019-09-05T06:46:42.369Z] 06:46:42 INFO - check> self = <selftest.XPCShellTestsTests testMethod=testAddTaskSkip>
[task 2019-09-05T06:46:42.369Z] 06:46:42 INFO - check>
[task 2019-09-05T06:46:42.369Z] 06:46:42 INFO - check> def testAddTaskSkip(self):
[task 2019-09-05T06:46:42.369Z] 06:46:42 INFO - check> self.writeFile("test_tasks_skip.js", ADD_TASK_SKIP)
[task 2019-09-05T06:46:42.370Z] 06:46:42 INFO - check> self.writeManifest(["test_tasks_skip.js"])
[task 2019-09-05T06:46:42.370Z] 06:46:42 INFO - check>
[task 2019-09-05T06:46:42.370Z] 06:46:42 INFO - check> > self.assertTestResult(True)
[task 2019-09-05T06:46:42.370Z] 06:46:42 INFO - check>
[task 2019-09-05T06:46:42.370Z] 06:46:42 INFO - check> ..\testing\xpcshell\selftest.py:1091:
[task 2019-09-05T06:46:42.370Z] 06:46:42 INFO - check> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
[task 2019-09-05T06:46:42.371Z] 06:46:42 INFO - check> ..\testing\xpcshell\selftest.py:537: in assertTestResult
[task 2019-09-05T06:46:42.371Z] 06:46:42 INFO - check> """ % ("passed" if expected else "failed", self.log.getvalue()))
[task 2019-09-05T06:46:42.371Z] 06:46:42 INFO - check> E AssertionError: Tests should have passed, log:
[task 2019-09-05T06:46:42.371Z] 06:46:42 INFO - check> E ========
[task 2019-09-05T06:46:42.371Z] 06:46:42 INFO - check> E runxpcshelltests.py | using symbolizer at z:\build\build\src\obj-firefox\dist\bin\llvm-symbolizer.exe
[task 2019-09-05T06:46:42.371Z] 06:46:42 INFO - check> E Found node at z:/build/fetches/node/node.exe
[task 2019-09-05T06:46:42.371Z] 06:46:42 INFO - check> E Found moz-http2 at z:\build\build\src\testing\xpcshell\moz-http2\moz-http2.js
[task 2019-09-05T06:46:42.371Z] 06:46:42 INFO - check> E Running tests sequentially.
[task 2019-09-05T06:46:42.372Z] 06:46:42 INFO - check> E SUITE-START | Running 1 tests
[task 2019-09-05T06:46:42.372Z] 06:46:42 INFO - check> E profile dir is c:\users\task_1567657386\appdata\local\temp\xpcshell\xpcshellprofile
[task 2019-09-05T06:46:42.372Z] 06:46:42 INFO - check> E TEST-START | test_tasks_skip.js
[task 2019-09-05T06:46:42.372Z] 06:46:42 INFO - check> E TEST-UNEXPECTED-TIMEOUT | test_tasks_skip.js | Test timed out
[task 2019-09-05T06:46:42.372Z] 06:46:42 INFO - check> E TEST-INFO took 15000ms
[task 2019-09-05T06:46:42.372Z] 06:46:42 INFO - check> E xpcshell return code: 1
[task 2019-09-05T06:46:42.372Z] 06:46:42 INFO - check> E INFO | Result summary:
[task 2019-09-05T06:46:42.372Z] 06:46:42 INFO - check> E INFO | Passed: 0
[task 2019-09-05T06:46:42.373Z] 06:46:42 INFO - check> E INFO | Failed: 1
[task 2019-09-05T06:46:42.373Z] 06:46:42 INFO - check> E INFO | Todo: 0
[task 2019-09-05T06:46:42.373Z] 06:46:42 INFO - check> E INFO | Retried: 0
[task 2019-09-05T06:46:42.373Z] 06:46:42 INFO - check> E SUITE-END | took 15s
[task 2019-09-05T06:46:42.373Z] 06:46:42 INFO - check> E Node moz-http2 server shutting down ...
[task 2019-09-05T06:46:42.373Z] 06:46:42 INFO - check> E Process stderr
[task 2019-09-05T06:46:42.373Z] 06:46:42 WARNING - check> E (node:3484) ExperimentalWarning: The http2 module is an experimental API.
[task 2019-09-05T06:46:42.373Z] 06:46:42 INFO - check> E
[task 2019-09-05T06:46:42.373Z] 06:46:42 INFO - check> E
[task 2019-09-05T06:46:42.374Z] 06:46:42 INFO - check> E ========
[task 2019-09-05T06:46:42.374Z] 06:46:42 INFO - check> ____________________ XPCShellTestsTests.testAddTaskSkipAll ____________________
[task 2019-09-05T06:46:42.374Z] 06:46:42 INFO - check>

Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Flags: needinfo?(gbrown)
Whiteboard: [stockwell needswork:owner]

The recent osx failure is a mis-classification and not related. The remainder of the failures for the last 30 days are all on Windows, primarily windows2012-64/asan. All failures are during build tasks, run via selftest.py: the same test appears to be running reliably in xpcshell test tasks on all platforms, including Windows.

Flags: needinfo?(gbrown)
See Also: → 1380470

Didn't mean to clear my ni yet!

Flags: needinfo?(gbrown)

Let's continue looking at this in the dup'd bug...

Assignee: nobody → gbrown
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Flags: needinfo?(gbrown)
Resolution: --- → DUPLICATE
Whiteboard: [stockwell needswork:owner]
You need to log in before you can comment on or make changes to this bug.