Remove "tree" from the site data preferences

RESOLVED FIXED in Firefox 61

Status

()

enhancement
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Paolo, Assigned: johannh)

Tracking

(Blocks 2 bugs)

Trunk
Firefox 61
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

a year ago
<tree id="sitesTree"> can be replaced with a listbox.
(Assignee)

Comment 1

a year ago
I can take this one, there's still a revision of bug 1421737 where I rewrote this using a listbox...
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
(Reporter)

Comment 2

a year ago
Great! :-)
Comment hidden (mozreview-request)
(Reporter)

Comment 4

a year ago
mozreview-review
Comment on attachment 8965642 [details]
Bug 1446368 - Remove the XUL tree from siteDataRemoveSelected.

https://reviewboard.mozilla.org/r/234506/#review240132

::: browser/components/preferences/siteDataRemoveSelected.xul:49
(Diff revision 1)
>      <separator />
>  
>      <vbox flex="1">
>        <label>&siteTree3.label;</label>
>        <separator class="thin"/>
> -      <tree id="sitesTree" flex="1" seltype="single" hidecolumnpicker="true">
> +      <listbox id="removalList"></listbox>

nit: close with />

::: browser/themes/shared/incontentprefs/siteDataSettings.css
(Diff revision 1)
>  #removing-label {
>    font-weight: bold;
>  }
> -
> -#sitesTree {
> -  height: 15em;

This seems to work fine on OS X, just make sure that the dialog height is still fine on all platforms, especially with many entries.
Attachment #8965642 - Flags: review?(paolo.mozmail) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 6

a year ago
So, uhm, on Windows with this patch applied, with too many elements in the list, my browser panics at "Resolving style on unstyled element". I'm not sure how to get a better trace on Windows for this right now.

Emilio, you might want to look into that panic. I'm happy to help.
Flags: needinfo?(emilio)
FTR, str:

13:53 <johannh> import the patch locally
13:54 <johannh> go to about:preferences#privacy
13:54 <johannh> go to cookies and site data and click manage data
13:54 <johannh> select, well, more than 10? sites and delete (though there needs to be at least one site left that is not deleted)

I can't get to it without a patch for bug 1442183 though. Any chance you have one, even if it's a hacky one to let me debug this?
Flags: needinfo?(emilio) → needinfo?(jhofmann)
(Assignee)

Comment 8

a year ago
(In reply to Emilio Cobos Álvarez [:emilio] from comment #7)
> FTR, str:
> 
> 13:53 <johannh> import the patch locally
> 13:54 <johannh> go to about:preferences#privacy
> 13:54 <johannh> go to cookies and site data and click manage data
> 13:54 <johannh> select, well, more than 10? sites and delete (though there
> needs to be at least one site left that is not deleted)
> 
> I can't get to it without a patch for bug 1442183 though. Any chance you
> have one, even if it's a hacky one to let me debug this?

Oh, sorry, I meant select and remove each one individually and then click "Save Changes", and I can even reproduce for just more than one (e.g. two) sites.
Flags: needinfo?(jhofmann)
Comment hidden (mozreview-request)

Comment 10

a year ago
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/47284c0bd982
Remove the XUL tree from siteDataRemoveSelected. r=Paolo

Comment 11

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/47284c0bd982
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.