Remove "tree" from the translation preferences

NEW
Unassigned

Status

()

enhancement
P3
normal
a year ago
6 months ago

People

(Reporter: Paolo, Unassigned)

Tracking

(Blocks 2 bugs)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 affected)

Details

(Reporter)

Description

a year ago
<tree id="languagesTree"> and <tree id="sitesTree"> can be replaced with listboxes. The translation feature is currently disabled by default.
(Reporter)

Comment 1

6 months ago
This comes up regularly. Can we just remove the Translation code? Who can make that call?

I'm concerned that as we leave the feature behind a preference for so long, its implementation and design might be getting further away from its real release requirements, so if we ever decide to ship it, we would be surprised that what we thought was a pref flip actually requires much more work. I'm wondering whether maintaining it is stating to hit diminishing returns, and it would cost less to reimplement an MVP by resurrecting the relevant parts of the code from version control once designers, product, and UX commit to shipping the feature again.

Needinfo for a few people, if you feel you have an answer, feel free to clear the other needinfos, or add more as needed.
Flags: needinfo?(gijskruitbosch+bugs)
Flags: needinfo?(felipc)
Flags: needinfo?(dtownsend)
Flags: needinfo?(dolske)
Flags: needinfo?(bgrinstead)

Comment 2

6 months ago
Passing my buck to Florian, who I think was last in touch with product about this.
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(florian)
(Reporter)

Comment 3

6 months ago
Another thought is that the general strategy seems to be that this kind of features could be installed through contextual recommendations and even live as WebExtensions that can expand beyond Firefox, so we might find out later that having that code in product might not even be what we wanted from a product perspective.
(In reply to :Paolo Amadini from comment #1)
> This comes up regularly. Can we just remove the Translation code?

No, there's a Shield study expected to go out in the next few months (I expect to know more about the actual date of the experiment by the end of the month).

I did the little back-end work we needed, nhnt11 will be doing the front-end, Cindy is the product manager.

We expect the UI in the shield study to be a doorhanger rather than a notification bar, so it may be possible to remove the translation notification bar. Although removing it before we have the new UI in place means we wouldn't be able to test the feature anymore, and would lose test coverage.
Flags: needinfo?(florian)
(Reporter)

Comment 5

6 months ago
Thanks, nice to see there's activity! I guess the study enables the preferences UI as well, so we'll have to convert these instances of <tree>?
Flags: needinfo?(florian)
Flags: needinfo?(felipc)
Flags: needinfo?(dtownsend)
Flags: needinfo?(dolske)
Flags: needinfo?(bgrinstead)
(In reply to :Paolo Amadini from comment #5)
> Thanks, nice to see there's activity! I guess the study enables the
> preferences UI as well, so we'll have to convert these instances of <tree>?

The preferences UI wasn't part of the UX mockups I saw this year, so I don't know. nhnt11, do you know?
Flags: needinfo?(florian) → needinfo?(nhnt11)
No, the design spec for the study does not touch the preferences UI. We are not studying user interaction with that UI - only the doorhanger usage. Let me know if this doesn't fully answer the question.
Flags: needinfo?(nhnt11)
You need to log in before you can comment on or make changes to this bug.