1446401 - Start to dispatch keydown/keyup events even during composition in Nightly and early Beta

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

For following the other browsers and conforming to UI Events spec, we should dispatch keydown/keyup events even during composition.

First, we should start to do it in Nightly and early Beta to collect regression reports.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d62b6d0ab3116f4f2d4a3bb2643abb4469746434

Comment 2

[Masatoshi Kimura [:emk]]

Are Gmail/GDoc issues resolved?

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

(In reply to Masatoshi Kimura [:emk] from comment #2)
> Are Gmail/GDoc issues resolved?

Do you know some bugs in Gmail and/or Google Docs? (This is different from bug 1440189.)

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

Posted to dev-platform:
https://groups.google.com/forum/#!topic/mozilla.dev.platform/oZEz5JH9ZK8

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

Attachment: Bug 1446401 - Start to dispatch "keydown" event and "keyup" event even during in composition in Nightly and early Beta

For confirming to UI Events spec, we should dispatch "keydown" event and
"keyup" event even during in composition.

This patch makes only Nightly and early Beta start to dispatch those events
during a composition.

Review commit: https://reviewboard.mozilla.org/r/228902/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228902/

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8960110 [details]
Bug 1446401 - Start to dispatch "keydown" event and "keyup" event even during in composition in Nightly and early Beta

https://reviewboard.mozilla.org/r/228902/#review234544

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0de39bcd318
Start to dispatch "keydown" event and "keyup" event even during in composition in Nightly and early Beta r=smaug

Comment 8

[Masatoshi Kimura [:emk]]

(In reply to Masayuki Nakano [:masayuki] (JST, +0900) from comment #3)
> Do you know some bugs in Gmail and/or Google Docs? (This is different from
> bug 1440189.)

Ah, sorry, I confused this bug with bug 1440189.

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/a0de39bcd318

Comment 10

[Kohei Yoshino [:kohei]]

Posted the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2018/keydown-and-keyup-events-will-soon-be-fired-during-ime-composition/