1446427 - Convert Autoclassify panel to ReactJS

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect, P1)

Description

[Cameron Dawson [:camd]]

This panel's time has come to migrate over to React.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3414

Comment 2

[Cameron Dawson [:camd]]

Comment on attachment 8965788 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3414

I made those fixes we discussed.  Thanks for working through that with me.  This is such a nicer solution to that "dangerous" stuff.  :)

Comment 3

[James Graham [:jgraham]]

Comment on attachment 8965788 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3414

Well it was a lot of code to review in detail, but it generally looks much nicer than before. Good work!

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/5d237353598a531337fc91c6e09a32a03d9b457a
Bug 1446427 - Convert Autoclassify panel to ReactJS (#3414)

Comment 5

[Cameron Dawson [:camd]]

Thanks James and everyone who helped out with this!  :)

Comment 6

[Ed Morley [:emorley]]

Don't know if this got lost in the email notifications? :-)
https://github.com/mozilla/treeherder/pull/3414#discussion_r183863561

Comment 7

[Cameron Dawson [:camd]]

OK, this has been fixed and checked in.  Thanks for spotting that!