1446517 - move some webrequest auth tests to xpcshell

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, enhancement)

Comment 1

[Kris Maglione [:kmag]]

Please yes...

Comment 2

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1446517 - move some webRequest auth tests to xpcshell,

Review commit: https://reviewboard.mozilla.org/r/228508/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228508/

Comment 3

[Kris Maglione [:kmag]]

Comment on attachment 8959679 [details]
Bug 1446517 - move some webRequest auth tests to xpcshell,

https://reviewboard.mozilla.org/r/228508/#review234356

Thank you!

::: toolkit/components/extensions/test/xpcshell/test_ext_webRequest_auth.js:14
(Diff revision 1)
> -    xhr.open("GET", url);
> -    xhr.onload = resolve;
> -    xhr.onabort = reject;
> -    xhr.onerror = reject;
> -    xhr.send();
> -  });
> +const server = createHttpServer({hosts: HOSTS});
> +
> +const BASE_URL = "http://example.com";
> +
> +// Save seen realms for cache checking.
> +let realms = [];

Nit: This should probably be a `Set`

::: toolkit/components/extensions/test/xpcshell/test_ext_webRequest_auth.js:46
(Diff revision 1)
> -}
> +  }
>  
> -function getAuthHandler(result, blocking = true) {
> -  function background(result) {
> +  response.setHeader("Content-Type", "text/plain; charset=UTF-8", false);
> +  if (proxy_realm && !request.hasHeader("Proxy-Authorization")) {
> +    // We're not testing anything that requires checking the proxy auth user/password.
> +    response.setStatusLine("1.0", 407, "Proxy authentication required");

Nit: Template string, please.

::: toolkit/components/extensions/test/xpcshell/test_ext_webRequest_auth.js:127
(Diff revision 1)
> +        extension.awaitMessage("onBeforeRequest"),
> +        extension.awaitMessage("onCompleted"),
> +      ]);
> +    }),
> +  ]);
> +  // let body = await testXHR(requestUrl);

Remove?

::: toolkit/components/extensions/test/xpcshell/test_ext_webRequest_auth.js:135
(Diff revision 1)
> +  events = Promise.all([
> +    extension.awaitMessage("onBeforeRequest"),
> +    extension.awaitMessage("onCompleted"),
> +  ]);

No need for this dance. Just do both awaitMessages after you load the content page. Same above, really... and below.

Comment 4

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8959679 [details]
Bug 1446517 - move some webRequest auth tests to xpcshell,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/228508/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/982d2108e78d
move some webRequest auth tests to xpcshell, r=kmag

Comment 6

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/982d2108e78d