Closed
Bug 1446527
Opened 6 years ago
Closed 6 years ago
Get rid of nsIDOMUIEvent
Categories
(Core :: DOM: Events, enhancement, P2)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(7 files)
4.74 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
4.25 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
6.93 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
4.73 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
5.92 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
14.29 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
14.04 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
No description provided.
![]() |
Assignee | |
Updated•6 years ago
|
Assignee: nobody → bzbarsky
Component: DOM → DOM: Events
Updated•6 years ago
|
Priority: -- → P2
![]() |
Assignee | |
Comment 1•6 years ago
|
||
MozReview-Commit-ID: 86cMORXSV9u
Attachment #8960869 -
Flags: review?(kyle)
![]() |
Assignee | |
Comment 2•6 years ago
|
||
MozReview-Commit-ID: GlTgti53Akj
Attachment #8960870 -
Flags: review?(kyle)
![]() |
Assignee | |
Comment 3•6 years ago
|
||
MozReview-Commit-ID: 9KqSXRUIc8G
Attachment #8960871 -
Flags: review?(kyle)
![]() |
Assignee | |
Comment 4•6 years ago
|
||
MozReview-Commit-ID: 6F9Q6kOogEo
Attachment #8960872 -
Flags: review?(kyle)
![]() |
Assignee | |
Comment 5•6 years ago
|
||
MozReview-Commit-ID: IPzWAakqHN4
Attachment #8960873 -
Flags: review?(kyle)
![]() |
Assignee | |
Comment 6•6 years ago
|
||
MozReview-Commit-ID: 7GbifGJQUtQ
Attachment #8960874 -
Flags: review?(kyle)
![]() |
Assignee | |
Comment 7•6 years ago
|
||
We no longer have multiple inheritance from nsIDOMEvent anywhere. This looks like it saves 20KB of codesize or so. MozReview-Commit-ID: qJtM7QNu9z
Attachment #8960875 -
Flags: review?(kyle)
Updated•6 years ago
|
Attachment #8960869 -
Flags: review?(kyle) → review+
Updated•6 years ago
|
Attachment #8960870 -
Flags: review?(kyle) → review+
Updated•6 years ago
|
Attachment #8960871 -
Flags: review?(kyle) → review+
Updated•6 years ago
|
Attachment #8960872 -
Flags: review?(kyle) → review+
Updated•6 years ago
|
Attachment #8960873 -
Flags: review?(kyle) → review+
Updated•6 years ago
|
Attachment #8960874 -
Flags: review?(kyle) → review+
Updated•6 years ago
|
Attachment #8960875 -
Flags: review?(kyle) → review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/899c9f492988 part 1. Remove rangeParent/rangeOffset members from nsIDOMUIEvent. r=qdot https://hg.mozilla.org/integration/mozilla-inbound/rev/b2169fd28b66 part 2. Remove nsIDOMUIEvent::GetDetail. r=qdot https://hg.mozilla.org/integration/mozilla-inbound/rev/04ce1f71a72b part 3. Remove nsIDOMUIEvent::AsEvent. r=qdot https://hg.mozilla.org/integration/mozilla-inbound/rev/b3c4650657af part 4. Remove nsIDOMUIEvent::SCROLL_PAGE_* constants. r=qdot https://hg.mozilla.org/integration/mozilla-inbound/rev/be7e5f1bd0a1 part 5. Remove unused nsIDOMUIEvent bits. r=qdot https://hg.mozilla.org/integration/mozilla-inbound/rev/357845bfcad2 part 6. Remove nsIDOMUIEvent. r=qdot https://hg.mozilla.org/integration/mozilla-inbound/rev/dc93e64c63e9 part 7. Remove the various NS_FORWARD_TO_EVENT bits. r=qdot
Comment 9•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/899c9f492988 https://hg.mozilla.org/mozilla-central/rev/b2169fd28b66 https://hg.mozilla.org/mozilla-central/rev/04ce1f71a72b https://hg.mozilla.org/mozilla-central/rev/b3c4650657af https://hg.mozilla.org/mozilla-central/rev/be7e5f1bd0a1 https://hg.mozilla.org/mozilla-central/rev/357845bfcad2 https://hg.mozilla.org/mozilla-central/rev/dc93e64c63e9
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•