Closed
Bug 1446542
Opened 6 years ago
Closed 6 years ago
Long-press on saved logins in about:logins should bring up context menu
Categories
(Firefox for Android Graveyard :: Logins, Passwords and Form Fill, defect, P1)
Firefox for Android Graveyard
Logins, Passwords and Form Fill
All
Android
Tracking
(firefox61 verified)
VERIFIED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | verified |
People
(Reporter: mbrubeck, Assigned: mbrubeck)
Details
(Keywords: ux-consistency)
Attachments
(1 file)
Steps to reproduce: 1. Navigate to about:logins in Firefox for Android 2. Press-and-hold on a saved login Expected results: Context menu appears Actual results: Nothing happens
Comment hidden (mozreview-request) |
Updated•6 years ago
|
Component: Settings and Preferences → Logins, Passwords and Form Fill
Attachment #8959701 -
Flags: review?(sdaswani)
Comment 2•6 years ago
|
||
I investigated this issue and this patch is a simple and clean solution and there should be no side-effects since the element is created dynamically. Nice!
Attachment #8959701 -
Flags: review?(sdaswani) → review+
Attachment #8959701 -
Flags: review?(michael.l.comella)
Assignee | ||
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8959701 [details] Bug 1446542 - Handle contextmenu events on about:logins on Android. https://reviewboard.mozilla.org/r/228528/#review237182
Attachment #8959701 -
Flags: review+
Assignee | ||
Updated•6 years ago
|
Attachment #8959701 -
Flags: review+ → review?(sdaswani)
Comment on attachment 8959701 [details] Bug 1446542 - Handle contextmenu events on about:logins on Android. https://reviewboard.mozilla.org/r/228528/#review237192 R+
Attachment #8959701 -
Flags: review?(sdaswani) → review+
Pushed by mbrubeck@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7886e5d9f94a Handle contextmenu events on about:logins on Android. r=mbrubeck
Priority: -- → P1
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7886e5d9f94a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Comment 7•6 years ago
|
||
Verified as fixed on latest Nightly build (61.0a1 - 2018/04/17). Device: Google Pixel (Android 8.1.0. Long tap on saved logins brings up context menu.
Status: RESOLVED → VERIFIED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•