1446558 - js/xpconnect/tests/unit/test_defineModuleGetter.js inadvertently requires all services on Services.jsm to "work" in an xpcshell environment (also on android)

Status: NEW

(Core :: XPConnect, enhancement, P2)

Description

[:Gijs (he/him)]

The combination of js/xpconnect/tests/unit/test_defineModuleGetter.js and bug 1446554 accidentally means that every single service exposed on Services.jsm needs to survive being instantiated without a profile, in an xpcshell environment.

If we want to test that, we should write a sane, contained test for this purpose in https://dxr.mozilla.org/mozilla-central/source/toolkit/modules/tests , with reasonable error messages.

For js/xpconnect/tests/unit/test_defineModuleGetter.js, it would be better if we used a more innocuous (testing-only?) module to verify the behaviour of defineModuleGetter.

Comment 1

[Kris Maglione [:kmag]]

It seems like this is a bug with Assert.jsm more than it is with the test.