1446595 - Intermittent devtools/client/inspector/fonts/test/browser_fontinspector_copy-URL.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -

Status: RESOLVED INCOMPLETE

(DevTools :: Inspector, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: nbeleuzu [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=168663697&repo=autoland

https://queue.taskcluster.net/v1/task/IMadotLzRpeBSDhr2TSsuw/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Julian Descottes [:jdescottes]]

Looking at the logs we can still see the huge logs which I expected to see removed via Bug 1440609.

Comment 2

[Julian Descottes [:jdescottes]]

The logging actually comes from a React middleware which is enabled in all tests by https://searchfox.org/mozilla-central/rev/6e96a3f1e44e286ddae5fdafab737709741d237a/devtools/client/inspector/store.js#18-26

Let's see if removing the logs improve the runtime or if it is unrelated to the timeout
https://treeherder.mozilla.org/#/jobs?repo=try&revision=da478b466c796dce43e580f1c5b494d97d4f478d

Comment 3

[Julian Descottes [:jdescottes]]

I think this only happens on non-e10s runs, because in this case the actor is fully serialized on the client when logging the action. Ultimately I think it would be nice to cleanup this action so that it doesn't have a pointer to an actor, but for the time being, I think we should just skip on non-e10s.

Comment 4

[Julian Descottes [:jdescottes]]

Try push on non e10s without the log: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e858213283df961285f79fa6f80085d1ab29acdd

Comment 5

[Julian Descottes [:jdescottes]]

Test only takes 10 seconds without the log on debug+non-e10s, so it looks like the assumption in comment 3 is correct.

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1446595 - skip fontinspector copyURL test on non-e10s;

On non e10s, the action logger from shared/redux/middleware/logs
will log serialized actors everytime a font-related action is logged
which slows down the tests a lot on those platforms.

Review commit: https://reviewboard.mozilla.org/r/228610/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228610/

Comment 7

[Intermittent Failures Robot]

10 failures in 814 pushes (0.012 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 8
* mozilla-inbound: 1
* mozilla-central: 1

Platform breakdown:
* linux32: 10

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1446595&startday=2018-03-12&endday=2018-03-18&tree=all

Comment 8

[Julian Descottes [:jdescottes]]

Bug 1444327 was backed out, so we should handle the fix directly in the original Bug.

Comment 9

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup