Get rid of nsIDOMProcessingInstruction

RESOLVED FIXED in Firefox 61

Status

()

enhancement
P2
normal
RESOLVED FIXED
Last year
5 months ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

unspecified
mozilla61
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(4 attachments)

No description provided.
MozReview-Commit-ID: EZVcDlMO3ev
Attachment #8959771 - Flags: review?(nika)
Priority: -- → P2
Attachment #8959768 - Flags: review?(nika) → review+
Comment on attachment 8959769 [details] [diff] [review]
part 2.  Stop using nsIDOMProcessingInstruction in webbrowserpersist

Review of attachment 8959769 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webbrowserpersist/WebBrowserPersistLocalDocument.cpp
@@ +884,2 @@
>      // Fixup xml-stylesheet processing instructions
> +    if (auto nodeAsPI =

I'm mildly suspicious that this will throw off the no-autoable static analysis (can't remember the exact conditions), but perhaps not.

It might be nice to write the type down, even though it'll be pretty verbose.
Attachment #8959769 - Flags: review?(nika) → review+
Attachment #8959770 - Flags: review?(nika) → review+
Attachment #8959771 - Flags: review?(nika) → review+
> I'm mildly suspicious that this will throw off the no-autoable static analysis

It's green on try.
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/deb82c55b928
part 1.  Stop using nsIDOMProcessingInstruction in serializers.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/2baafa65d3bb
part 2.  Stop using nsIDOMProcessingInstruction in webbrowserpersist.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6b58233ebb3
part 3.  Stop using nsIDOMProcessingInstruction in the XML content sink.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/910c72f13436
part 4.  Remove nsIDOMProcessingInstruction.  r=mystor
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.