1446599 - Get rid of nsIDOMProcessingInstruction

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Stop using nsIDOMProcessingInstruction in serializers

MozReview-Commit-ID: loUmk0rNYV

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Stop using nsIDOMProcessingInstruction in webbrowserpersist

MozReview-Commit-ID: 51QLffCZeW1

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Stop using nsIDOMProcessingInstruction in the XML content sink

MozReview-Commit-ID: 2v2aA37nYfH

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 4. Remove nsIDOMProcessingInstruction

MozReview-Commit-ID: EZVcDlMO3ev

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 8959769 [details] [diff] [review]
part 2.  Stop using nsIDOMProcessingInstruction in webbrowserpersist

Review of attachment 8959769 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webbrowserpersist/WebBrowserPersistLocalDocument.cpp
@@ +884,2 @@
>      // Fixup xml-stylesheet processing instructions
> +    if (auto nodeAsPI =

I'm mildly suspicious that this will throw off the no-autoable static analysis (can't remember the exact conditions), but perhaps not.

It might be nice to write the type down, even though it'll be pretty verbose.

Comment 6

[Boris Zbarsky [:bzbarsky]]

> I'm mildly suspicious that this will throw off the no-autoable static analysis

It's green on try.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/deb82c55b928
part 1.  Stop using nsIDOMProcessingInstruction in serializers.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/2baafa65d3bb
part 2.  Stop using nsIDOMProcessingInstruction in webbrowserpersist.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6b58233ebb3
part 3.  Stop using nsIDOMProcessingInstruction in the XML content sink.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/910c72f13436
part 4.  Remove nsIDOMProcessingInstruction.  r=mystor

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/deb82c55b928
https://hg.mozilla.org/mozilla-central/rev/2baafa65d3bb
https://hg.mozilla.org/mozilla-central/rev/b6b58233ebb3
https://hg.mozilla.org/mozilla-central/rev/910c72f13436