signal name 'selection_changed' is invalid
Categories
(Core :: Disability Access APIs, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: tomasz.warniello, Assigned: jdiggs)
References
Details
Attachments
(2 files)
1.19 KB,
patch
|
Details | Diff | Splinter Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Build ID: 20180314232927 Steps to reproduce: Nothing in particular. Actual results: My syslog is full of this entry: /build/glib2.0-B1uXKV/glib2.0-2.50.3/./gobject/gsignal.c:3492: signal name 'selection_changed' is invalid for instance '0x7f043f11ba60' of type 'MaiAtkType139' The count goes in thousands a day. Linux uuuuu 4.9.0-6-amd64 #1 SMP Debian 4.9.82-1+deb9u3 (2018-03-02) x86_64 GNU/Linux Firefox-ESR 52.7.1 (64-bit) Expected results: The log should be clean.
Reporter | ||
Comment 1•6 years ago
|
||
Now I see this is connected to the activity of text selection in the browser. There is more than one log entry for each character selected, so it seems. Eg. selecting one character produces three log entries. But selecting 7 characters produces only 12 entries. The entries are all the same.
Hi Tomasz, Can you clarify on the Steps to Reproduce? Would that be the information in Comment 1?
Updated•6 years ago
|
Reporter | ||
Comment 3•6 years ago
|
||
Yes, the description is in the first comment.
Comment 5•6 years ago
|
||
I'm seeing this too, on Firefox 60.2.2 as packaged by Debian (60.2.2esr-1~deb9u1). It's definitely annoying! (firefox-esr:468002): GLib-GObject-WARNING **: /build/glib2.0-B1uXKV/glib2.0-2.50.3/./gobject/gsignal.c:3492: signal name 'selection_changed' is invalid for instance '0x7f51e32146f0' of type 'MaiAtkType139'
Comment 6•5 years ago
|
||
I have this issue too (firefox:22747): GLib-GObject-WARNING **: 15:06:58.059: ../glib/gobject/gsignal.c:3492: signal name 'selection_changed' is invalid for instance '0x7fec0d7b9e20' of type 'MaiAtkType139' It is shown every time selection changes. I may have another issue related. While selecting firefox crashes and force closes consuming a lot of CPU https://crash-stats.mozilla.com/report/index/2e07031d-2dd9-41f5-92f9-9bbd90181114 Linux XX4423 4.18.16-arch1-1-ARCH #1 SMP PREEMPT Sat Oct 20 22:06:45 UTC 2018 x86_64 GNU/Linux
Comment 7•5 years ago
|
||
This still reproduces on Firefox 60.3.0esr (64-bit).
Comment 8•5 years ago
|
||
Also on Firefox 60.6.1esr-1 (64-bit).
Comment 9•5 years ago
|
||
Also on Firefox 65.0.2
Linux notebook 5.0.0-arch1-1-ARCH #1 SMP PREEMPT Mon Mar 4 14:11:43 UTC 2019 x86_64 GNU/Linux
Comment 10•5 years ago
|
||
(In reply to gabriel.schanuel from comment #9)
Also on Firefox 65.0.2
Linux notebook 5.0.0-arch1-1-ARCH #1 SMP PREEMPT Mon Mar 4 14:11:43 UTC 2019 x86_64 GNU/Linux
I actually have more issues with it.
I select text for copying, every now and then firefox crashes while selecting
Firefox crashes without a crash report after selecting for a while.
Comment 11•5 years ago
|
||
I confirm the issue with latest release 66.0.3 (64-bit) on Arch linux
Assignee | ||
Comment 12•5 years ago
|
||
Moving this to Disability Access APIs because that's what ATK is.
@jamie: This console spew is pretty annoying. And it would probably be more performant to not bother attempting to emit events which are not supported on a given role. Any chance you could take a look? Thanks in advance!
Comment 13•5 years ago
|
||
Marking confirmed because Joanie. :)
I'm not sure (and I haven't tested this yet), but I suspect this is because we're mapping Gecko's EVENT_TEXT_SELECTION_CHANGED to ATK selection_changed for ProxyAccessibles (content documents in content processes):
https://searchfox.org/mozilla-central/rev/ee806041c6f76cc33aa3c9869107ca87cb3de371/accessible/atk/AccessibleWrap.cpp#1344
Instead, this should be mapped to ATK text_selection_changed.
Assignee | ||
Comment 14•5 years ago
|
||
Assignee | ||
Comment 15•5 years ago
|
||
Comment on attachment 9070998 [details] [diff] [review] 0001-Bug-1446699-Fix-ATK-mapping-for-EVENT_TEXT_SELECTION.patch Jamie: Thanks! That was indeed the problem. Patch attached.
Comment 16•5 years ago
|
||
Comment on attachment 9070998 [details] [diff] [review] 0001-Bug-1446699-Fix-ATK-mapping-for-EVENT_TEXT_SELECTION.patch Thanks! Patch looks great, but unfortunately, old style patch reviews have been completely phased out. Patches need to be submitted to Phabricator. See https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html It looks like you're using git (rather than hg), in which case you might find [Phlay](https://github.com/mystor/phlay) easier than Arcanist/moz-phab. Aside from anything else, it is a single Python script and doesn't have any other dependencies.
Comment 17•5 years ago
|
||
Alternatively, I can just submit the patch myself, but it wouldn't be attributed correctly.
Assignee | ||
Comment 18•5 years ago
|
||
Oops, didn't realize about Phabricator. I have some personal appointments today, but then I'll sort out Phabricator and friends and submit the patch correctly. Thanks for the review and tips!
Comment 19•5 years ago
|
||
mozilla-inbound still alive, you can attach a patch and change its review flags, so while Phab is used quite often these days indeed, it seems you still have an option to do old days approach.
(In reply to James Teh [:Jamie] from comment #17)
Alternatively, I can just submit the patch myself, but it wouldn't be attributed correctly.
if landing the patch manually, then I believe you can use -u option to commit and set Joanie as author.
Assignee | ||
Comment 20•5 years ago
|
||
The correct mapping for nsIAccessibleEvent::EVENT_TEXT_SELECTION_CHANGED
in ATK is text_selection_changed; not selection_changed. The latter is
meant for containers which support selection of child objects, such as
a menu or expanded select element.
Assignee | ||
Comment 21•5 years ago
|
||
Comment on attachment 9071288 [details]
Bug 1446699 - Fix ATK mapping for EVENT_TEXT_SELECTION_CHANGED
Patch uploaded to/via phabriactor (in theory).
Comment 22•5 years ago
|
||
Pushed by jteh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e402a0d8195e Fix ATK mapping for EVENT_TEXT_SELECTION_CHANGED r=Jamie
Comment 23•5 years ago
|
||
Comment on attachment 9071288 [details]
Bug 1446699 - Fix ATK mapping for EVENT_TEXT_SELECTION_CHANGED
It worked. :)
Comment 24•5 years ago
|
||
bugherder |
Comment 25•4 years ago
|
||
This affects ESR68, should it be uplifted?
Comment 26•4 years ago
|
||
Spurious logging isn't ideal, but I'm also not sure that's a reasonable candidate for ESR uplift? The patch is low risk, FWIW.
Comment 27•2 years ago
|
||
I am running 95.0.2 and my .xsession-errors log is still flooded with the same error.. 2 years later.
signal name 'load_complete' is invalid for instance '0x7fcb46e0d230' of type 'MaiAtkType139'
Is there a work-around ?
Comment 28•2 years ago
|
||
Should have mentioned I am running Debian Sid fully up to date.
Comment 29•2 years ago
|
||
This is a slightly different error - load_complete rather than selection_changed - and will thus require a different fix. Could you please file a separate bug? Thanks.
Description
•