1446729 - Move IME classes to o.m.geckoview

Status: RESOLVED FIXED

(GeckoView :: IME, enhancement, P3)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

GeckoEditable and GeckoInputConnection are part of "client-side" GeckoView, and should therefore be in o.m.geckoview. Moving the classes also lets us hide the internal interfaces inside TextInputController from generated javadoc.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1446729 - 1. Get rid of DebugGeckoInputConnection;

DebugGeckoInputConnection was a wrapper around GeckoInputConnection to
log InputConnection calls. Move its functionality to
GeckoInputConnection.wrapForDebug, so we don't have a secondary class in
GeckoInputConnection.java.

Review commit: https://reviewboard.mozilla.org/r/228708/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228708/

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1446729 - 2. Rename TextInputController to SessionTextInput;

Following the naming scheme "SessionFoo" for GeckoSession sub-objects,
and "getFoo()" for getters of GeckoSession sub-objects, rename
TextInputController to SessionTextInput and getTextInputController() to
getTextInput().

Review commit: https://reviewboard.mozilla.org/r/228710/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228710/

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1446729 - 3. Move GeckoEditable/InputConnection to o.m.geckoview;

Moving GeckoEditable and GeckoInputConnection to o.m.geckoview lets us
make the interfaces inside SessionTextInput package-private, so they
don't show up in the docs.

Review commit: https://reviewboard.mozilla.org/r/228712/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228712/

Comment 4

[Eugen Sawin [:esawin]]

Comment on attachment 8959940 [details]
Bug 1446729 - 1. Get rid of DebugGeckoInputConnection;

https://reviewboard.mozilla.org/r/228708/#review237102

Comment 5

[Eugen Sawin [:esawin]]

Comment on attachment 8959941 [details]
Bug 1446729 - 2. Rename TextInputController to SessionTextInput;

https://reviewboard.mozilla.org/r/228710/#review237104

::: commit-message-3634f:3
(Diff revision 1)
> +Bug 1446729 - 2. Rename TextInputController to SessionTextInput; r?esawin
> +
> +Following the naming scheme "SessionFoo" for GeckoSession sub-objects,

Are we dropping the Gecko prefix?

Comment 6

[Eugen Sawin [:esawin]]

Comment on attachment 8959942 [details]
Bug 1446729 - 3. Move GeckoEditable/InputConnection to o.m.geckoview;

https://reviewboard.mozilla.org/r/228712/#review237106

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8959941 [details]
Bug 1446729 - 2. Rename TextInputController to SessionTextInput;

https://reviewboard.mozilla.org/r/228710/#review237104

> Are we dropping the Gecko prefix?

People usually access `SessionFoo` through `GeckoSession.getFoo()`, and so I think it's okay to drop the Gecko prefix to be less verbose.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80da46bebc63
1. Get rid of DebugGeckoInputConnection; r=esawin
https://hg.mozilla.org/integration/autoland/rev/a33d7ab2f52d
2. Rename TextInputController to SessionTextInput; r=esawin
https://hg.mozilla.org/integration/autoland/rev/0157d05549cb
3. Move GeckoEditable/InputConnection to o.m.geckoview; r=esawin

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/80da46bebc63
https://hg.mozilla.org/mozilla-central/rev/a33d7ab2f52d
https://hg.mozilla.org/mozilla-central/rev/0157d05549cb

Comment 10

[Chris Peterson [:cpeterson]]

Moving some IME bugs to the new GeckoView::IME component.