Closed Bug 1446729 Opened 2 years ago Closed 2 years ago

Move IME classes to o.m.geckoview

Categories

(GeckoView :: General, enhancement, P3)

All
Android
enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: jchen, Assigned: jchen)

Details

Attachments

(3 files)

GeckoEditable and GeckoInputConnection are part of "client-side" GeckoView, and should therefore be in o.m.geckoview. Moving the classes also lets us hide the internal interfaces inside TextInputController from generated javadoc.
Comment on attachment 8959940 [details]
Bug 1446729 - 1. Get rid of DebugGeckoInputConnection;

https://reviewboard.mozilla.org/r/228708/#review237102
Attachment #8959940 - Flags: review?(esawin) → review+
Comment on attachment 8959941 [details]
Bug 1446729 - 2. Rename TextInputController to SessionTextInput;

https://reviewboard.mozilla.org/r/228710/#review237104

::: commit-message-3634f:3
(Diff revision 1)
> +Bug 1446729 - 2. Rename TextInputController to SessionTextInput; r?esawin
> +
> +Following the naming scheme "SessionFoo" for GeckoSession sub-objects,

Are we dropping the Gecko prefix?
Attachment #8959941 - Flags: review?(esawin) → review+
Comment on attachment 8959942 [details]
Bug 1446729 - 3. Move GeckoEditable/InputConnection to o.m.geckoview;

https://reviewboard.mozilla.org/r/228712/#review237106
Attachment #8959942 - Flags: review?(esawin) → review+
Comment on attachment 8959941 [details]
Bug 1446729 - 2. Rename TextInputController to SessionTextInput;

https://reviewboard.mozilla.org/r/228710/#review237104

> Are we dropping the Gecko prefix?

People usually access `SessionFoo` through `GeckoSession.getFoo()`, and so I think it's okay to drop the Gecko prefix to be less verbose.
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/80da46bebc63
1. Get rid of DebugGeckoInputConnection; r=esawin
https://hg.mozilla.org/integration/autoland/rev/a33d7ab2f52d
2. Rename TextInputController to SessionTextInput; r=esawin
https://hg.mozilla.org/integration/autoland/rev/0157d05549cb
3. Move GeckoEditable/InputConnection to o.m.geckoview; r=esawin
https://hg.mozilla.org/mozilla-central/rev/80da46bebc63
https://hg.mozilla.org/mozilla-central/rev/a33d7ab2f52d
https://hg.mozilla.org/mozilla-central/rev/0157d05549cb
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 61 → mozilla61
You need to log in before you can comment on or make changes to this bug.