1446732 - Assert not called when using @AssertCalled(count = 0)

Status: RESOLVED FIXED

(GeckoView :: General, defect, P3)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Currently "count = 0" means any number greater than 0, but it's more intuitive for @AssertCalled(count = 0) to be a synonym of @AssertCalled(false)

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1446732 - 1. Add more test rule testcases;

Add tests for passing through exceptions, @AssertCalled(count = 0)
annotations, and synthesizeTap calls.

Review commit: https://reviewboard.mozilla.org/r/228716/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228716/

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1446732 - 2. Make @AssertCalled(count = 0) more intuitive;

Make @AssertCalled(count = 0) the same as @AssertCalled(false), which is
more intuitive. The default behavior of @AssertCalled(true) is still one
or more calls, with an implicit count = -1.

Review commit: https://reviewboard.mozilla.org/r/228718/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228718/

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8959945 [details]
Bug 1446732 - 1. Add more test rule testcases;

https://reviewboard.mozilla.org/r/228716/#review235184

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8959946 [details]
Bug 1446732 - 2. Make @AssertCalled(count = 0) more intuitive;

https://reviewboard.mozilla.org/r/228718/#review235186

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ca29ae04950
1. Add more test rule testcases; r=snorp
https://hg.mozilla.org/integration/autoland/rev/9d09b3ce2dc3
2. Make @AssertCalled(count = 0) more intuitive; r=snorp

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/5ca29ae04950
https://hg.mozilla.org/mozilla-central/rev/9d09b3ce2dc3