1446814 - Deleting Website settings on shutdown doesn't delete Notification settings

Status: RESOLVED WORKSFORME

(Firefox :: Untriaged, defect)

Description

[lennard]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20100101

Steps to reproduce:

(( translating from the Dutch gui, so exact words may be inaccurate ))

Allow a website to send 'Push notifications'

Then disallow new websites to do so.
3-bar - Settings - Privacy & Security - Permissions - Notifications - Settings - Checkmark: Block new requests
Save Settings

Then configure Firefox to delete Website preferences upon shutdown:
3-bar - Settings - Privacy & Security - History - Checkmark: Erase History upon Firefox shutdown    and under it's Settings     Check "Website preferences"
Shut Down and restart Firefox

The website can't send push messages anymore as the settings to do so have been removed by the actions above.

When I however remove the checkmark which prevents new sites to request the permission to send push messages, the tested site doesn't/can't request the permission. (it never pops up anymore)


Actual results:

Firefox has removed my website preferences, which allows the site to send me Push messages.
Firefox however has NOT removed the line from  notificationstore.json   file in my profile-directory. This causes the website not to be able to re-register itself for allowing to send push messages.

By removing the entry from the     notificationstore.json    file and restart Firefox, the website can reregister itself.


Expected results:

I think the entries should also have been removed from the notificationstore.json file too, or the registration-process should ignore so the contents of the json file.

Comment 1

[Emil Pasca [:emilpasca]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0

I have tested this issue on Windows 10 x64 with the latest Firefox release (59.0.1) and the latest Nightly (61.0a1-20180321040527) and haven't managed to reproduce the issue.

After navigating to "web.skype.com" and confirm to allow "Push Notifications", when turning on the "Checkmark: Block new requests" and also applining the Website preferences upon shutdown as mentioned in the description, on browser restart no more push notifications are sent.
However, if toggling off the "Checkmark: Block new requests" and refreshing the  "web.skype.com" page, the allow "Push Notifications" dialog is displayed again, when confirming this, I am able to receive notifications.


Could you please retest this using the latest Firefox release and latest Nightly build and report back the results?  (You can download the latest Nightly build from here https://goo.gl/57dpxn)
When doing this, please use a new clean Firefox profile, maybe even safe mode, to eliminate custom settings as a possible cause (https://goo.gl/AR5o9d).

Comment 2

[lennard]

You're right. It appears to have been fixed in 59.0.1. I am no longer able to reproduce the error.

Comment 3

[Emil Pasca [:emilpasca]]

Based on Comment 2 from the reporter, changing status to RESOLVED WORKS FOR ME.

If anyone can reproduce it on latest versions, feel free to reopen the issue and provide more information.