1446815 - add source shas in checksums

Status: VERIFIED FIXED

(Release Engineering :: Release Automation, enhancement)

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

In releasetasks, we used to have it. See https://archive.mozilla.org/pub/firefox/candidates/58.0b9-candidates/build1/SHA256SUMS
Not anymore in the in-tree stuff. Let's add it.

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Bug 1446815 - add custom flexibility for checksums filename

Comment 3

[Mihai Tabara [:mtabara]⌚️GMT]

Firsst attempt to solve the in-tree part: https://hg.mozilla.org/projects/maple/rev/b7eafd965f5dad12c1914f32c610e0d23fb220e8

Comment 4

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8971988 [details] [review]
Bug 1446815 - add custom flexibility for checksums filename

@aki: sorry to flood with this but you've got most of the context since we've chatted lastly about this. Feel free to redirect to tprince or jlorenzo if your plate is full. Nothing urgent here.

Comment 5

[Mihai Tabara [:mtabara]⌚️GMT]

Second patch to fix some deps on maple: https://hg.mozilla.org/projects/maple/rev/fb06b0189f2f3a3971b999b765680dc4d276ebe5

Comment 6

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: In-tree changes to support checksums for source tasks

@aki:

Quick question, was I supposed to set the "only attributes: nightly" within the two new kinds I've added? Initially I did but the graph would flush them out if so. I'm slightly confused why.

Comment 7

[Mihai Tabara [:mtabara]⌚️GMT]

Note to self: double check that the staging releases I've triggered for Firefox, Fennec and Devedition are resulting in green jobs and with source checksums where they should be.

Comment 8

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #7)
> Note to self: double check that the staging releases I've triggered for
> Firefox, Fennec and Devedition are resulting in green jobs and with source
> checksums where they should be.

http://ftp.stage.mozaws.net/pub/mobile/candidates/61.0b9-candidates/build10/SHA256SUMS

Comment 9

[Aki Sasaki (not active)]

(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #6)
> Quick question, was I supposed to set the "only attributes: nightly" within
> the two new kinds I've added? Initially I did but the graph would flush them
> out if so. I'm slightly confused why.

That's probably because the upstream tasks don't have the nightly attribute set. I think they should have them set, but we can probably address that later.

Comment 10

[Aki Sasaki (not active)]

Comment on attachment 8972281 [details] [diff] [review]
In-tree changes to support checksums for source tasks

>diff --git a/taskcluster/taskgraph/transforms/beetmover_source_checksums.py b/taskcluster/taskgraph/transforms/beetmover_source_checksums.py
>new file mode 100644
>--- /dev/null
>+++ b/taskcluster/taskgraph/transforms/beetmover_source_checksums.py
>@@ -0,0 +1,166 @@
>+# This Source Code Form is subject to the terms of the Mozilla Public
>+# License, v. 2.0. If a copy of the MPL was not distributed with this
>+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
>+"""
>+Transform the checksums signing task into an actual task description.

checksums source?

Comment 11

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to Aki Sasaki [:aki] from comment #10)
> Comment on attachment 8972281 [details] [diff] [review]
> In-tree changes to support checksums for source tasks
> 
> >diff --git a/taskcluster/taskgraph/transforms/beetmover_source_checksums.py b/taskcluster/taskgraph/transforms/beetmover_source_checksums.py
> >new file mode 100644
> >--- /dev/null
> >+++ b/taskcluster/taskgraph/transforms/beetmover_source_checksums.py
> >@@ -0,0 +1,166 @@
> >+# This Source Code Form is subject to the terms of the Mozilla Public
> >+# License, v. 2.0. If a copy of the MPL was not distributed with this
> >+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
> >+"""
> >+Transform the checksums signing task into an actual task description.
> 
> checksums source?

Good catch, I'll amend with a follow-up in-tree. Slippery copy-paste :)

Comment 12

[Mihai Tabara [:mtabara]⌚️GMT]

Fixed this https://hg.mozilla.org/projects/maple/rev/b13e5626ac9fb05fec6ea293019e6c588b9a5f5a

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2c2199bb1e91
add source shas in release checksums. r=aki a=release

Comment 14

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/2c2199bb1e91

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/build/puppet/rev/6c3f01daff88
bump beetmoverscript version in beetmoverworkers. r=versionbump

Comment 16

[Mihai Tabara [:mtabara]⌚️GMT]

This will get uplifted by RelMan/sherriff while doing the normal merges from central -> beta this week so it'll end up there anyway. This is done now.

Comment 17

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Nicely renaming of the beetmover source kind to match tree consistency

Comment 18

[Mihai Tabara [:mtabara]⌚️GMT]

Landed https://hg.mozilla.org/projects/maple/rev/7b33e1765372bb178a33e67a3a161d102c536906 to fix the consistency naming.

Comment 19

[Mihai Tabara [:mtabara]⌚️GMT]

https://archive.mozilla.org/pub/devedition/candidates/61.0b2-candidates/build1/SHA256SUMS

61.0b2 devedition has the source shas included.

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d78b83757f4c
cleanup in naming beetmover source checksums for consistency. r=tomprince

Comment 21

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d78b83757f4c