Closed Bug 1446815 Opened 2 years ago Closed Last year

add source shas in checksums

Categories

(Release Engineering :: Release Automation: Other, enhancement)

enhancement
Not set

Tracking

(firefox61 fixed)

VERIFIED FIXED
Tracking Status
firefox61 --- fixed

People

(Reporter: mtabara, Assigned: mtabara)

Details

Attachments

(3 files)

No description provided.
In releasetasks, we used to have it. See https://archive.mozilla.org/pub/firefox/candidates/58.0b9-candidates/build1/SHA256SUMS
Not anymore in the in-tree stuff. Let's add it.
Comment on attachment 8971988 [details] [review]
Bug 1446815 - add custom flexibility for checksums filename

@aki: sorry to flood with this but you've got most of the context since we've chatted lastly about this. Feel free to redirect to tprince or jlorenzo if your plate is full. Nothing urgent here.
Attachment #8971988 - Flags: review?
@aki:

Quick question, was I supposed to set the "only attributes: nightly" within the two new kinds I've added? Initially I did but the graph would flush them out if so. I'm slightly confused why.
Attachment #8972281 - Flags: review?(aki)
Attachment #8971988 - Flags: review? → review?(aki)
Note to self: double check that the staging releases I've triggered for Firefox, Fennec and Devedition are resulting in green jobs and with source checksums where they should be.
(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #7)
> Note to self: double check that the staging releases I've triggered for
> Firefox, Fennec and Devedition are resulting in green jobs and with source
> checksums where they should be.

http://ftp.stage.mozaws.net/pub/mobile/candidates/61.0b9-candidates/build10/SHA256SUMS
Attachment #8971988 - Flags: review?(aki) → review+
(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #6)
> Quick question, was I supposed to set the "only attributes: nightly" within
> the two new kinds I've added? Initially I did but the graph would flush them
> out if so. I'm slightly confused why.

That's probably because the upstream tasks don't have the nightly attribute set. I think they should have them set, but we can probably address that later.
Comment on attachment 8972281 [details] [diff] [review]
In-tree changes to support checksums for source tasks

>diff --git a/taskcluster/taskgraph/transforms/beetmover_source_checksums.py b/taskcluster/taskgraph/transforms/beetmover_source_checksums.py
>new file mode 100644
>--- /dev/null
>+++ b/taskcluster/taskgraph/transforms/beetmover_source_checksums.py
>@@ -0,0 +1,166 @@
>+# This Source Code Form is subject to the terms of the Mozilla Public
>+# License, v. 2.0. If a copy of the MPL was not distributed with this
>+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
>+"""
>+Transform the checksums signing task into an actual task description.

checksums source?
Attachment #8972281 - Flags: review?(aki) → review+
(In reply to Aki Sasaki [:aki] from comment #10)
> Comment on attachment 8972281 [details] [diff] [review]
> In-tree changes to support checksums for source tasks
> 
> >diff --git a/taskcluster/taskgraph/transforms/beetmover_source_checksums.py b/taskcluster/taskgraph/transforms/beetmover_source_checksums.py
> >new file mode 100644
> >--- /dev/null
> >+++ b/taskcluster/taskgraph/transforms/beetmover_source_checksums.py
> >@@ -0,0 +1,166 @@
> >+# This Source Code Form is subject to the terms of the Mozilla Public
> >+# License, v. 2.0. If a copy of the MPL was not distributed with this
> >+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
> >+"""
> >+Transform the checksums signing task into an actual task description.
> 
> checksums source?

Good catch, I'll amend with a follow-up in-tree. Slippery copy-paste :)
Pushed by mtabara@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2c2199bb1e91
add source shas in release checksums. r=aki a=release
https://hg.mozilla.org/mozilla-central/rev/2c2199bb1e91
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Pushed by mtabara@mozilla.com:
https://hg.mozilla.org/build/puppet/rev/6c3f01daff88
bump beetmoverscript version in beetmoverworkers. r=versionbump
This will get uplifted by RelMan/sherriff while doing the normal merges from central -> beta this week so it'll end up there anyway. This is done now.
Attachment #8972841 - Flags: review?(mozilla) → review+
https://archive.mozilla.org/pub/devedition/candidates/61.0b2-candidates/build1/SHA256SUMS

61.0b2 devedition has the source shas included.
Status: RESOLVED → VERIFIED
Pushed by mtabara@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d78b83757f4c
cleanup in naming beetmover source checksums for consistency. r=tomprince
You need to log in before you can comment on or make changes to this bug.