1446821 - Add shutdown blocker for async uninstall operations

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement)

Description

[Kris Maglione [:kmag]]

Several of our tests currently race when running async uninstall operations at xpcshell shutdown time. These conditions should all use shutdown blockers to make sure they actually complete.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1446821: Add shutdown blocker for async extension uninstall tasks.

Review commit: https://reviewboard.mozilla.org/r/228804/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228804/

Comment 2

[Michal Novotny [:michal]]

Can we get landed this soon, please? This blocks 1373708.

Comment 3

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8960037 [details]
Bug 1446821: Add shutdown blocker for async extension uninstall tasks.

https://reviewboard.mozilla.org/r/228804/#review235260

Comment 4

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3518de30af30f44ba9656722705a580de3012616
Bug 1446821: Add shutdown blocker for async extension uninstall tasks. r=mixedpuppy

Comment 5

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/3518de30af30

Comment 6

[CosminB]

Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!