Closed Bug 1446868 Opened 4 years ago Closed 4 years ago

Replace update.rdf support code with a preprocessor

Categories

(Toolkit :: Add-ons Manager, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

Details

Attachments

(2 files)

This should be a stepping stone to fully removing support for update.rdf manifests. It will let us test the behavior of the preprocessor in a single test, and use only JSON update manifests in the rest of the update tests.
Comment on attachment 8960074 [details]
Bug 1446868: Part 1 - Preprocess RDF update manifests into JSON format.

https://reviewboard.mozilla.org/r/228854/#review235272
Attachment #8960074 - Flags: review?(aswan) → review+
Comment on attachment 8960075 [details]
Bug 1446868: Part 2 - Convert remaining update.rdf tests to JSON format.

https://reviewboard.mozilla.org/r/228856/#review235332

::: toolkit/mozapps/extensions/test/browser/browser_install.rdf:1
(Diff revision 1)
> -<?xml version="1.0" encoding="UTF-8"?>
> +{

why isn't this renamed to .json
Attachment #8960075 - Flags: review?(aswan) → review+
Comment on attachment 8960075 [details]
Bug 1446868: Part 2 - Convert remaining update.rdf tests to JSON format.

https://reviewboard.mozilla.org/r/228856/#review235332

> why isn't this renamed to .json

Because it's referenced in a signed add-on's install manifest, so I can't rename it without re-signing or doing some sort of redirect. It works regardless of the extension, though.
https://hg.mozilla.org/integration/mozilla-inbound/rev/48834182306edfb64a5e28d94ea83867780be32f
Bug 1446868: Part 1 - Preprocess RDF update manifests into JSON format. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/e0821b952a013e2fe551cb2a87973effe13167f7
Bug 1446868: Part 2 - Convert remaining update.rdf tests to JSON format. r=aswan
https://hg.mozilla.org/integration/mozilla-inbound/rev/885915481ec51089613bf2f36985bcd77b17e08a
Bug 1446868: Follow-up: Fix xpcshell tests in unexpected directory. r=bustage DONTBUILD
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.