1446868 - Replace update.rdf support code with a preprocessor

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement)

Description

[Kris Maglione [:kmag]]

This should be a stepping stone to fully removing support for update.rdf manifests. It will let us test the behavior of the preprocessor in a single test, and use only JSON update manifests in the rest of the update tests.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1446868: Part 1 - Preprocess RDF update manifests into JSON format.

Review commit: https://reviewboard.mozilla.org/r/228854/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228854/

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1446868: Part 2 - Convert remaining update.rdf tests to JSON format.

Review commit: https://reviewboard.mozilla.org/r/228856/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228856/

Comment 3

[Andrew Swan [:aswan]]

Comment on attachment 8960074 [details]
Bug 1446868: Part 1 - Preprocess RDF update manifests into JSON format.

https://reviewboard.mozilla.org/r/228854/#review235272

Comment 4

[Andrew Swan [:aswan]]

Comment on attachment 8960075 [details]
Bug 1446868: Part 2 - Convert remaining update.rdf tests to JSON format.

https://reviewboard.mozilla.org/r/228856/#review235332

::: toolkit/mozapps/extensions/test/browser/browser_install.rdf:1
(Diff revision 1)
> -<?xml version="1.0" encoding="UTF-8"?>
> +{

why isn't this renamed to .json

Comment 5

[Kris Maglione [:kmag]]

Comment on attachment 8960075 [details]
Bug 1446868: Part 2 - Convert remaining update.rdf tests to JSON format.

https://reviewboard.mozilla.org/r/228856/#review235332

> why isn't this renamed to .json

Because it's referenced in a signed add-on's install manifest, so I can't rename it without re-signing or doing some sort of redirect. It works regardless of the extension, though.

Comment 6

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/48834182306edfb64a5e28d94ea83867780be32f
Bug 1446868: Part 1 - Preprocess RDF update manifests into JSON format. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/e0821b952a013e2fe551cb2a87973effe13167f7
Bug 1446868: Part 2 - Convert remaining update.rdf tests to JSON format. r=aswan

Comment 7

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/885915481ec51089613bf2f36985bcd77b17e08a
Bug 1446868: Follow-up: Fix xpcshell tests in unexpected directory. r=bustage DONTBUILD

Comment 8

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/48834182306e
https://hg.mozilla.org/mozilla-central/rev/e0821b952a01
https://hg.mozilla.org/mozilla-central/rev/885915481ec5