1446929 - dom/media/Benchmark.cpp only supports video

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Christian Holler (:decoder)]

Currently, the Benchmark class only seems to support video input judging from this code:

https://searchfox.org/mozilla-central/rev/3abf6fa7e2a6d9a7bfb88796141b0f012e68c2db/dom/media/Benchmark.cpp#180

I rewrote the code as follows:

> -      mTrackDemuxer =
> -        mDemuxer->GetTrackDemuxer(TrackInfo::kVideoTrack, 0);
> +      if (mDemuxer->GetNumberTracks(TrackInfo::kVideoTrack)) {
> +        mTrackDemuxer =
> +          mDemuxer->GetTrackDemuxer(TrackInfo::kVideoTrack, 0);
> +      } else if (mDemuxer->GetNumberTracks(TrackInfo::kAudioTrack)) {
> +        mTrackDemuxer =
> +          mDemuxer->GetTrackDemuxer(TrackInfo::kAudioTrack, 0);
> +      }

Does this look like the right approach? And does it make sense to support more than one audio/video track?

I can attach a proper patch for review if this is the right way to go.

Comment 1

[Christian Holler (:decoder)]

Setting needinfo for :jya to confirm the approach in comment 0 or suggest an alternative that I can implement.

Comment 2

[Jean-Yves Avenard [:jya]]

that or following the current style.
      mTrackDemuxer =
        mDemuxer->GetTrackDemuxer(TrackInfo::kVideoTrack, 0);
      if (!mTrackDemuxer) {
          mTrackDemuxer =
            mDemuxer->GetTrackDemuxer(TrackInfo::kVideoTrack, 0);
          if (!mTrackDemuxer) {
              MainThreadShutdown();
              return;
          }
      }


the one you suggest looks better though

Comment 3

[Christian Holler (:decoder)]

Attachment: Bug 1446929 - Support audio files in media Benchmark class.

Review commit: https://reviewboard.mozilla.org/r/231556/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231556/

Comment 4

[Jean-Yves Avenard [:jya]]

Comment on attachment 8962686 [details]
Bug 1446929 - Support audio files in media Benchmark class.

https://reviewboard.mozilla.org/r/231556/#review237054

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc9024c91420
Support audio files in media Benchmark class. r=jya

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/fc9024c91420