Closed Bug 1446949 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 10091 - Fix sizing of orthogonal elements with percentage margins

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 10091 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10091
Details from upstream follow.

Manuel Rego Casasnovas <rego@igalia.com> wrote:
>  Fix sizing of orthogonal elements with percentage margins
>  
>  LayoutBox::FillAvailableMeasure() was not considering the case of
>  orthogonal elements when computing the margins.
>  The margins ended up being properly calculated but the size of
>  the orthogonal elements was wrong, as they considered
>  to have more or less space than the available one.
>  
>  The method is modified in order to use
>  the containing block inline size in order to resolve the percentages:
>  https://www.w3.org/TR/css-writing-modes-3/#dimension-mapping
>  
>  BUG=808758
>  TEST=external/wpt/css/css-writing-modes/sizing-orthogonal-percentage-margin-00*.html
>  
>  Change-Id: Ib8c81dcd14589b3fefe806de3f8f75c000b1cac9
>  Reviewed-on: https://chromium-review.googlesource.com/968522
>  WPT-Export-Revision: 5a7c7e4026bd9444cedaae1b60f042ece131d40d
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 8 tests
PASS   : 8
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/564cc5a6ee8e
[wpt PR 10091] - Fix sizing of orthogonal elements with percentage margins, a=testonly
https://hg.mozilla.org/mozilla-central/rev/564cc5a6ee8e
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.