Closed
Bug 1446949
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 10091 - Fix sizing of orthogonal elements with percentage margins
Categories
(Core :: CSS Parsing and Computation, enhancement, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 10091 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/w3c/web-platform-tests/pull/10091 Details from upstream follow. Manuel Rego Casasnovas <rego@igalia.com> wrote: > Fix sizing of orthogonal elements with percentage margins > > LayoutBox::FillAvailableMeasure() was not considering the case of > orthogonal elements when computing the margins. > The margins ended up being properly calculated but the size of > the orthogonal elements was wrong, as they considered > to have more or less space than the available one. > > The method is modified in order to use > the containing block inline size in order to resolve the percentages: > https://www.w3.org/TR/css-writing-modes-3/#dimension-mapping > > BUG=808758 > TEST=external/wpt/css/css-writing-modes/sizing-orthogonal-percentage-margin-00*.html > > Change-Id: Ib8c81dcd14589b3fefe806de3f8f75c000b1cac9 > Reviewed-on: https://chromium-review.googlesource.com/968522 > WPT-Export-Revision: 5a7c7e4026bd9444cedaae1b60f042ece131d40d
Reporter | ||
Updated•6 years ago
|
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Reporter | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=86aa6a381f0e09c4d9e56907c8a6e507b6c98448
Reporter | ||
Comment 2•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b339f617e4d2d7fe27c86196fbeaa9408c9c112e
Reporter | ||
Comment 3•6 years ago
|
||
Ran 8 tests PASS : 8
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/564cc5a6ee8e [wpt PR 10091] - Fix sizing of orthogonal elements with percentage margins, a=testonly
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/564cc5a6ee8e
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/564cc5a6ee8e
You need to log in
before you can comment on or make changes to this bug.
Description
•