Closed
Bug 1446964
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 10093 - scroll-snap-align should specify inline and block.
Categories
(Core :: CSS Parsing and Computation, enhancement, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 10093 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/w3c/web-platform-tests/pull/10093 Details from upstream follow. Sandra Sun <sunyunjia@chromium.org> wrote: > scroll-snap-align should specify inline and block. > > Currently, we parse the two values in scroll-snap-align for x and y. > However, according to the spec, > https://drafts.csswg.org/css-scroll-snap-1/#scroll-snap-align, the two > values specify the alignment in the inline axis and block axis. This > patch renames the two values and handles the vertical writing mode for > inline and block alignments. > > Bug: 821645 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > Change-Id: I78acff0df4698b3f9c0f7443e61e3bad75379b14 > > Reviewed-on: https://chromium-review.googlesource.com/967890 > WPT-Export-Revision: 76183a5b0f06aa368242726bffb72cc55076ecd7
Reporter | ||
Updated•6 years ago
|
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Reporter | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c1043050b3d531f903e56145dcdafbc545b9585
Reporter | ||
Comment 2•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5f94aa047bec826dd3f4efab35b74ce4fab4142
Reporter | ||
Comment 3•6 years ago
|
||
Ran 1 tests and 3 subtests OK : 1 FAIL : 3 New tests that have failures or other problems: /css/css-scroll-snap/snap-inline-block.html Snaps correctly for horizontal-tb writing mode with 'inline' and 'block' alignments: FAIL Snaps correctly for vertical-lr writing mode with 'inline' and 'block' alignments: FAIL Snaps correctly for vertical-rl writing mode with 'inline' and 'block' alignments: FAIL
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/597de9acebc7 [wpt PR 10093] - scroll-snap-align should specify inline and block., a=testonly
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/597de9acebc7
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/597de9acebc7
You need to log in
before you can comment on or make changes to this bug.
Description
•