1446993 - Intermittent dom/animation/test/mozilla/test_restyles.html | Finite transform animation in out-of-view element should never be throttled - got 18, expected 19

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: dluca [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=168928919&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/TKODTgx1RDuuuuzwMvJKnw/runs/0/artifacts/public/logs/live_backing.log

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Note that I did a try with tweaking the restyle count one more frame, it results "got 17, expected 18", something bad happens there. :/

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c20437d276d4014a6b85d7c2ce76662169c3e14b&selectedJob=169125249

Comment 3

[Intermittent Failures Robot]

56 failures in 822 pushes (0.068 failures/push) were associated with this bug in the last 7 days. 

This is the #21 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* autoland: 23
* mozilla-inbound: 14
* mozilla-central: 7
* mozilla-beta: 7
* try: 5

Platform breakdown:
* android-4-3-armv7-api16: 29
* linux32: 21
* windows10-64-ccov: 2
* linux32-stylo-disabled: 2
* osx-10-10: 1
* linux64-stylo-disabled: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1446993&startday=2018-03-20&endday=2018-03-26&tree=trunk

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Take this.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=92e4b16de48f88f87b196b08c35e8c0090a501ee

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1446993 - Observe restyling count in `fixed 20` frames instead of tweaked count.

In bug 1444177, I did accidentally replace the frame count with the tweaked
count.  The tweaked count represents that animation restyling should happen
the tweaked count times during *not-yet-tweaked* frame count.

Review commit: https://reviewboard.mozilla.org/r/231738/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231738/

Comment 7

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Comment on attachment 8962924 [details]
Bug 1446993 - Observe restyling count in `fixed 20` frames instead of tweaked count.

https://reviewboard.mozilla.org/r/231738/#review237342

Thank you!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8d754106493
Observe restyling count in `fixed 20` frames instead of tweaked count. r=birtles

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c8d754106493

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/098f8358feea

Comment 11

[Hiroyuki Ikezoe (:hiro)]

Thank you Ryan!

Comment 12

[Intermittent Failures Robot]

19 failures in 718 pushes (0.026 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-inbound: 9
* autoland: 6
* mozilla-beta: 4

Platform breakdown:
* android-4-3-armv7-api16: 14
* linux32: 4
* osx-10-10: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1446993&startday=2018-03-26&endday=2018-04-01&tree=trunk

Comment 13

[Hiroyuki Ikezoe (:hiro)]

All failures in comment 12 happened before landing the fix.