Closed Bug 1447018 Opened 4 years ago Closed 4 years ago

Don't use short-circuiting ||-operator in ToDateTimeOptions

Categories

(Core :: JavaScript: Internationalization API, enhancement, P3)

Product:
Core
Component:
JavaScript: Internationalization API
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: anba, Assigned: anba)

Details

Attachments

(1 file)

bug1447018.patch
4.32 KB, patch
Waldo
: review+
Details | Diff | Splinter Review 
ToDateTimeOptions, steps 4 and 5 call |Get(options, prop)| for all properties, so we can't use the ||-operator because of its short-circuiting semantics.
Attached patch bug1447018.patch — — Splinter Review 
Retrieve all properties in ToDateTimeOptions to improve spec-compliance...
Attachment #8960187 - Flags: review?(jwalden+bmo)
Attachment #8960187 - Flags: review?(jwalden+bmo) → review+
Priority: -- → P3
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d67329ad458
Don't break early in ToDateTimeOptions to improve spec conformance. r=Waldo
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6d67329ad458
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox61: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.