Closed
Bug 1447040
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 10096 - Correctly reject in-progress body methods with AbortError
Categories
(Core :: DOM: Service Workers, enhancement, P3)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 10096 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/w3c/web-platform-tests/pull/10096 Details from upstream follow. Adam Rice <ricea@chromium.org> wrote: > Correctly reject in-progress body methods with AbortError > > Prior to this change, response body methods such as > response.body.arrayBuffer() would reject with a TypeError if the fetch > was aborted. This change makes them correctly reject with an AbortError > instead. > > This implements stage #3 of the "Body Cancellation" section of the > design doc: > > https://docs.google.com/document/d/1OuoCG2uiijbAwbCw9jaS7tHEO0LBO_4gMNio1ox0qlY/edit#heading=h.fvc7d7q07oio > > Bug: 817687 > Change-Id: Ifde322d9c22485a8ba9d14fd4ffca65c4fb4745a > Reviewed-on: https://chromium-review.googlesource.com/954765 > WPT-Export-Revision: 3afc84fbdbbb5c22096a12cbaac52cbcf9b04cec
Reporter | ||
Updated•6 years ago
|
Component: web-platform-tests → DOM: Service Workers
Product: Testing → Core
Reporter | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=dbec0f7b61c252cae8f841192a8759a377a76598
Reporter | ||
Comment 2•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9a3da9b6aa99da5abfc4e2a7ef944d8928d51ac
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/ca3375f6ba92 [wpt PR 10096] - Correctly reject in-progress body methods with AbortError, a=testonly
Comment 5•6 years ago
|
||
Backed out for frequently failing wpt /service-workers/cache-storage/serviceworker/cache-abort.https.html Push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=ebfad4be630db7aa060c7d27a3724945e994d63a Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/0e164dfe2a02bbd5e971883b210433541078e1af Log: https://treeherder.mozilla.org/logviewer.html#?job_id=173760946&repo=mozilla-inbound&lineNumber=16530
Flags: needinfo?(james)
Backout by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/mozilla-inbound/rev/c985ffee008d Backed out changeset ca3375f6ba92 for frequently failing wpt /service-workers/cache-storage/serviceworker/cache-abort.https.html: fix test manifest
Backout by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/mozilla-inbound/rev/f61c1a429d05 Backed out changeset ca3375f6ba92 for frequently failing wpt /service-workers/cache-storage/serviceworker/cache-abort.https.html: remove files not removed because of conflict and re-run manifest udpate
Comment 8•6 years ago
|
||
Hmm, backing out individual components of a wptsync landing is a new one. Not sure how I feel about that, since it introduces the possibility that we drift relative to upstream, but also allows us to fix one issue without backing out the whole thing. My preferred solution would be to disable falky tests instead. Maybe there's some tooling I could write to make it easier for sheriffs to do that (like ./mach wpt-disable <test> <configuration>?) Note that OSX is hard to pretest because we don't have enough resources on that platform; this passed a stability test on other platforms. In this case I guess I'll increase the timeout and try again.
Flags: needinfo?(james)
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/d08958954094 [wpt PR 10096] - Correctly reject in-progress body methods with AbortError, a=testonly
Comment 10•6 years ago
|
||
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/61fd0798f0a8 Disable cache-abort serviceworker test on mac debug, a=testonly
Comment 11•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d08958954094 https://hg.mozilla.org/mozilla-central/rev/61fd0798f0a8
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•