Closed
Bug 1447066
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 10098 - Exit check_stability with an error when no tests run
Categories
(Testing :: web-platform-tests, enhancement, P4)
Testing
web-platform-tests
Tracking
(firefox61 fixed)
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 10098 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/w3c/web-platform-tests/pull/10098 Details from upstream follow. Robert Ma <robertma@chromium.org> wrote: > Exit check_stability with an error when no tests run > > Similar to #10030 (which was for `wpt run`), this commit makes `wpt > check-stability` return a non-zero exit code when no tests run. > > Also fix some code smells: > > * `run` was redefined by `do_delayed_imports` to a different function. > Rename the other `run` method in this module to `setup_and_run`. > * `retcode` was unnecessarily defined in the top scope. Remove it to > avoid redefinition. > * `global logger` and the call to `get_parser` were extraneous in `run` > (now `setup_and_run`) and hence are removed.
Reporter | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4b88ea5e30fff1b30b9a27718d08fe95565c88c
Reporter | ||
Comment 2•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=336700d736465c552e7b2d9e873fad50b02c89f5
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/9cfa39c68846 [wpt PR 10098] - Exit check_stability with an error when no tests run, a=testonly
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9cfa39c68846
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9cfa39c68846
You need to log in
before you can comment on or make changes to this bug.
Description
•