Closed Bug 1447066 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 10098 - Exit check_stability with an error when no tests run

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 10098 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10098
Details from upstream follow.

Robert Ma <robertma@chromium.org> wrote:
>  Exit check_stability with an error when no tests run
>  
>  Similar to #10030 (which was for `wpt run`), this commit makes `wpt
>  check-stability` return a non-zero exit code when no tests run.
>  
>  Also fix some code smells:
>  
>  * `run` was redefined by `do_delayed_imports` to a different function.
>    Rename the other `run` method in this module to `setup_and_run`.
>  * `retcode` was unnecessarily defined in the top scope. Remove it to
>    avoid redefinition.
>  * `global logger` and the call to `get_parser` were extraneous in `run`
>    (now `setup_and_run`) and hence are removed.
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9cfa39c68846
[wpt PR 10098] - Exit check_stability with an error when no tests run, a=testonly
https://hg.mozilla.org/mozilla-central/rev/9cfa39c68846
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.