Closed Bug 1447086 Opened 2 years ago Closed 2 years ago
.js should return a promise if no callback is provided in stop()
59 bytes, text/x-review-board-request
There are a large number of places (for example , , and certainly more) where we construct manual promises to stop the server in an async test, or rely on. This is just annoying and it could be easily fixed, so we should do it. Patch incoming, although I'm not sure who to request review from, feel free to reassign to someone better if I pick you. : https://searchfox.org/mozilla-central/search?q=server.stop(resolve)&case=false®exp=false&path= : https://searchfox.org/mozilla-central/search?q=promiseStopServer
Sorry, that first sentence should end with 'or rely on a helper function to do the same for us'.
Comment on attachment 8960285 [details] Bug 1447086 - Return a promise from stop() in httpd.js .mielczarek https://reviewboard.mozilla.org/r/229052/#review235036 This looks sensible. Thanks!
Attachment #8960285 - Flags: review?(ted) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/7a23c23c732a Return a promise from stop() in httpd.js r=ted.mielczarek
You need to log in before you can comment on or make changes to this bug.