1447091 - Fix non-unified build bustage in dom/media/

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Daniel Holbert [:dholbert]]

While investigating bug 1447070, I checked dom/media as well (dropping UNIFIED_ from its moz.build file to shake out non-unified build bustage), and found a few errors there:
=====
 0:16.07 ../../../mozilla/dom/media/MediaTimer.cpp: In member function ‘void mozilla::MediaTimer::DispatchDestroy()’:
 0:16.08 ../../../mozilla/dom/media/MediaTimer.cpp:50:3: error: ‘Unused’ was not declared in this scope
 0:16.08    Unused << rv;
 0:16.08    ^~~~~~


 0:19.56 ../../../mozilla/dom/media/FileMediaResource.cpp: In member function ‘void mozilla::FileMediaResource::EnsureSizeInitialized()’:
 0:19.56 ../../../mozilla/dom/media/FileMediaResource.cpp:30:36: error: invalid use of incomplete type ‘class mozilla::AbstractThread’
 0:19.56      mCallback->AbstractMainThread()->Dispatch(
 0:19.56                                     ^~
=====

Patch coming up to fix these errors.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1447091: Add #includes to fix non-unified bustage in dom/media.

This fixes these two errors:
FileMediaResource.cpp:30:36: error: invalid use of incomplete type ‘class mozilla::AbstractThread’
   mCallback->AbstractMainThread()->Dispatch(

MediaTimer.cpp:50:3: error: ‘Unused’ was not declared in this scope
   Unused << rv;

Review commit: https://reviewboard.mozilla.org/r/229060/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229060/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8960287 [details]
Bug 1447091: Add #includes to fix non-unified bustage in dom/media.

https://reviewboard.mozilla.org/r/229060/#review234848

Thank you for fixing these.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c4faed9b07d
Add #includes to fix non-unified bustage in dom/media. r=gerald

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/3c4faed9b07d