1447098 - Rename FromContent to FromNode

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

In bug 1446533 I changed FromContent to take an nsINode*, because that was useful in some places.  Turns out that compiles fine.  Given that, I'd like to rename it to nsINode.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Rename FromContent on various DOM classes to FromNode

MozReview-Commit-ID: 202nkbmkwfR

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Rename the NS_IMPL_FROMCONTENT macros to NS_IMPL_FROMNODE

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Add some FromNode overloads for different arg types

Some condition functions are faster on subclasses of nsINode than on nsINode itself.

Comment 4

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 8960772 [details] [diff] [review]
part 3.  Add some FromNode overloads for different arg types

Review of attachment 8960772 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsIContent.h
@@ +1013,3 @@
>  #define NS_IMPL_FROMNODE_HELPER(_class, _check)                         \
> +  template<typename ArgType>                                            \
> +  static _class* FromNode(ArgType* aNode)                               \

Hmm, this is a lot more overloads than seems like should be necessary...

This I think would let you avoid the need for a special overload for smart pointers

#define NS_IMPL_FROMNODE_HELPER(_class, _check) \
  template<typename ArgType> \
  static _class* FromNode(ArgType&& aNode) { \
    return aNode->_check ? static_cast<_class*>(static_cast<nsINode*>(aNode)) : nullptr; \
  }

Comment 5

[Boris Zbarsky [:bzbarsky]]

To preserve current semantics, we need something to handle "nsINode* -> Foo*", "const nsINode* -> const Foo*", "const RefPtr<nsINode> -> Foo*" (no const on the return type here).  I don't think the rvalue proposal does that (and in particular it fails to compile as-is when "const nsIContent*" is the ArgType; I did try it before ending up with the thing I have now).

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Now with fewer overloads

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb4e6e094d20
part 1.  Rename FromContent on various DOM classes to FromNode.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd041053a1b5
part 2.  Rename the NS_IMPL_FROMCONTENT macros to NS_IMPL_FROMNODE.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/7db110ae9111
part 3.  Add some FromNode overloads for different arg types.  r=mystor

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/eb4e6e094d20
https://hg.mozilla.org/mozilla-central/rev/fd041053a1b5
https://hg.mozilla.org/mozilla-central/rev/7db110ae9111