Closed Bug 1447144 Opened 6 years ago Closed 6 years ago

Add GuaranteePersistence to PushLayer in DrawTargetCapture

Categories

(Core :: Graphics: Layers, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: rhunt, Assigned: rhunt)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

It looks like in all other places we store a SourceSurface in DrawTargetCapture, we call GuaranteePersistence on it so some SourceSurfaces can alloc and copy borrowed memory into owned memory.

Not sure if this borrowed surfaces are actually used as mask surfaces, but it's good to fix I think.
Attachment #8960357 - Flags: review?(bas)
Comment on attachment 8960357 [details] [diff] [review]
persistence.patch

Review of attachment 8960357 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch.
Attachment #8960357 - Flags: review?(bas) → review+
Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8af210a4d4d0
Add GuaranteePersistence to PushLayer in DrawTargetCapture. (bug 1447144, r=bas)
https://hg.mozilla.org/mozilla-central/rev/8af210a4d4d0
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: