Closed Bug 1447145 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 10100 - Handle options for add_untested_idls

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 10100 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10100
Details from upstream follow.

Luke Bjerring <lukebjerring@chromium.org> wrote:
>  Handle options for add_untested_idls
>  
>  Currently, no way to import a subset of an IDL snippet as untested interfaces.
>  
>  Note that the order of checking for `should_skip` needs to change for a case such as:
>  IDL:
>  
>      interface A {}
>      interface B {}
>  
>      let text = await fetch('interfaces/foo.idl').then(r => r.text());
>      idlArray.add_untested_idls(text, {only: ['A'] });
>      idlArray.add_idls(text, {only: ['B'] });
>  
>  The `add_idls` encounters 'A' for a second time, and throws `Duplicate identifier`, in spite of the fact that it will be skipped.
Ran 104 tests and 20040 subtests
OK     : 102
PASS   : 17032
FAIL   : 3007
TIMEOUT: 3
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8100de6989ad
[wpt PR 10100] - Handle options for add_untested_idls, a=testonly
https://hg.mozilla.org/mozilla-central/rev/8100de6989ad
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.