Closed Bug 1447198 Opened 2 years ago Closed 2 years ago

event-emitter dumps all events in workers

Categories

(DevTools :: General, enhancement, P3)

enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: jryans, Assigned: jryans)

Details

Attachments

(1 file)

It appears we're always dumping events in workers (since there's no access to the dump pref there).

At the very least, the default should be false...  If needed, we can construct something more complex here.
Attachment #8960430 - Flags: review?(poirot.alex) → review?(jdescottes)
Comment on attachment 8960430 [details]
Bug 1447198 - Disable event emitter logging in DevTools.

https://reviewboard.mozilla.org/r/229212/#review236564

Looks like this default value was added in Bug 1003095 without much discussion.
Changing it now seems sane to me, if there are complaints we can introduce an easier way of enabling logs in workers (via an env variable maybe).
Attachment #8960430 - Flags: review?(jdescottes) → review+
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/cb2d946a1d8e
Disable event emitter logging in DevTools. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/cb2d946a1d8e
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.