Closed Bug 1447259 Opened 6 years ago Closed 6 years ago

Intermittent devtools/client/inspector/animation/test/browser_animation_summary-graph_computed-timing-path_different-timescale.js | A promise chain failed to handle a rejection: Minified React error #188

Categories

(DevTools :: Inspector: Animations, defect, P5)

defect

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: daisuke)

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:other])

Attachments

(1 file, 1 obsolete file)

Component: DOM: Animation → Developer Tools: Animation Inspector
Product: Core → Firefox
Assignee: nobody → dakatsuka
There are 33 failures in the past 7 days. 
Platforms:
- most of them are happening on OS X 10.10 debug, but we also have some occurrences on Windows 7 and windows10-64, both debug.
Recent log failure: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=170682180&lineNumber=9818
Relevant part of the log: 
23:04:22     INFO -  Buffered messages finished
23:04:22    ERROR -  310 INFO TEST-UNEXPECTED-FAIL | devtools/client/inspector/animation/test/browser_animation_summary-graph_computed-timing-path_different-timescale.js | A promise chain failed to handle a rejection: Minified React error #188; visit http://facebook.github.io/react/docs/error-decoder.html?invariant=188 for the full message or use the non-minified dev environment for full errors and additional helpful warnings. - stack: reactProdInvariant@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/vendor/react-dom.js:32:15
23:04:22     INFO -  findCurrentFiberUsingSlowPath@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/vendor/react-dom.js:3003:7
23:04:22     INFO -  findCurrentHostFiber@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/vendor/react-dom.js:3072:23
23:04:22     INFO -  findHostInstance@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/vendor/react-dom.js:10633:21
23:04:22     INFO -  findDOMNode@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/vendor/react-dom.js:12847:14
23:04:22     INFO -  updateState@resource://devtools/shared/base-loader.js -> resource://devtools/client/inspector/animation/components/graph/SummaryGraphPath.js:174:20
23:04:22     INFO -  async*componentWillReceiveProps@resource://devtools/shared/base-loader.js -> resource://devtools/client/inspector/animation/components/graph/SummaryGraphPath.js:53:5
23:04:22     INFO -  callComponentWillReceiveProps@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/vendor/react-dom.js:6244:5
23:04:22     INFO -  updateClassInstance@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/vendor/react-dom.js:6419:7
23:04:22     INFO -  updateClassComponent@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/vendor/react-dom.js:7537:22
23:04:22     INFO -  beginWork@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/vendor/react-dom.js:7883:16
23:04:22     INFO -  performUnitOfWork@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/vendor/react-dom.js:9706:16
23:04:22     INFO -  workLoop@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/vendor/react-dom.js:9753:26
23:04:22     INFO -  renderRoot@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/vendor/react-dom.js:9832:9
23:04:22     INFO -  performWorkOnRoot@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/vendor/react-dom.js:10465:24
23:04:22     INFO -  performWork@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/vendor/react-dom.js:10418:7
23:04:22     INFO -  requestWork@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/vendor/react-dom.js:10329:7
23:04:22     INFO -  scheduleWorkImpl@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/vendor/react-dom.js:10188:11
23:04:22     INFO -  scheduleWork@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/vendor/react-dom.js:10152:12
23:04:22     INFO -  enqueueSetState@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/vendor/react-dom.js:6131:7
23:04:22     INFO -  Component.prototype.setState@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/vendor/react.js:346:3
23:04:22     INFO -  onStateChange@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/vendor/react-redux.js:1412:11
23:04:22     INFO -  dispatch@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/vendor/redux.js:416:7
23:04:22     INFO -  log/</<@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/redux/middleware/log.js:17:5
23:04:22     INFO -  exports.history/</</<@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/redux/middleware/history.js:21:5
23:04:22     INFO -  waitUntilService/</<@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/redux/middleware/wait-service.js:59:18
23:04:22     INFO -  promiseMiddleware/</<@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/redux/middleware/promise.js:15:14
23:04:22     INFO -  thunk/</<@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/redux/middleware/thunk.js:16:9
23:04:22     INFO -  task/</<@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/redux/middleware/task.js:36:12
23:04:22     INFO -  updateState@resource://devtools/shared/base-loader.js -> resource://devtools/client/inspector/animation/animation.js:574:5
23:04:22     INFO -  setAnimationsCurrentTime@resource://devtools/shared/base-loader.js -> resource://devtools/client/inspector/animation/animation.js:376:7
23:04:22     INFO -  Async*onCurrentTimeTimerUpdated@resource://devtools/shared/base-loader.js -> resource://devtools/client/inspector/animation/animation.js:278:7
23:04:22     INFO -  next@resource://devtools/shared/base-loader.js -> resource://devtools/client/inspector/animation/current-time-timer.js:58:7
23:04:22     INFO -  FrameRequestCallback*next@resource://devtools/shared/base-loader.js -> resource://devtools/client/inspector/animation/current-time-timer.js:63:5
23:04:22     INFO -  FrameRequestCallback*next@resource://devtools/shared/base-loader.js -> resource://devtools/client/inspector/animation/current-time-timer.js:63:5
23:04:22     INFO -  FrameRequestCallback*next@resource://devtools/shared/base-loader.js -> resource://devtools/client/inspector/animation/current-time-timer.js:63:5
23:04:22     INFO -  FrameRequestCallback*next@resource://devtools/shared/base-loader.js -> resource://devtools/client/inspector/animation/current-time-timer.js:63:5
23:04:22     INFO -  start@resource://devtools/shared/base-loader.js -> resource://devtools/client/inspector/animation/current-time-timer.js:67:5
23:04:22     INFO -  startAnimationsCurrentTimeTimer@resource://devtools/shared/base-loader.js -> resource://devtools/client/inspector/animation/animation.js:522:5
23:04:22     INFO -  updateState@resource://devtools/shared/base-loader.js -> resource://devtools/client/inspector/animation/animation.js:577:7
23:04:22     INFO -  update@resource://devtools/shared/base-loader.js -> resource://devtools/client/inspector/animation/animation.js:541:7
23:04:22     INFO -  Async*emit@resource://devtools/shared/base-loader.js -> resource://devtools/shared/event-emitter.js:178:37
23:04:22     INFO -  emit@resource://devtools/shared/base-loader.js -> resource://devtools/shared/event-emitter.js:255:29
23:04:22     INFO -  setNodeFront@resource://devtools/shared/base-loader.js -> resource://devtools/client/framework/selection.js:128:5
23:04:22     INFO -  selectNode@chrome://mochitests/content/browser/devtools/client/inspector/test/shared-head.js:208:3
23:04:22     INFO -  async*selectNodeAndWaitForAnimations@chrome://mochitests/content/browser/devtools/client/inspector/animation/test/head.js:327:9
23:04:22     INFO -  async*@chrome://mochitests/content/browser/devtools/client/inspector/animation/test/browser_animation_summary-graph_computed-timing-path_different-timescale.js:13:9
23:04:22     INFO -  Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1076:21
23:04:22     INFO -  TaskImpl_run@resource://gre/modules/Task.jsm:326:42
23:04:22     INFO -  TaskImpl@resource://gre/modules/Task.jsm:275:3
23:04:22     INFO -  asyncFunction@resource://gre/modules/Task.jsm:247:14
23:04:22     INFO -  Task_spawn@resource://gre/modules/Task.jsm:161:12
23:04:22     INFO -  Tester_execTest@chrome://mochikit/content/browser-test.js:1067:9
23:04:22     INFO -  Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:967:9
23:04:22     INFO -  SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
23:04:22     INFO -  Rejection date: Tue Mar 27 2018 23:04:21 GMT+0000 (Coordinated Universal Time) - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 257
23:04:22     INFO -  Stack trace:
23:04:22     INFO -      resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:257
23:04:22     INFO -      chrome://mochikit/content/browser-test.js:Tester_execTest/<:1098
23:04:22     INFO -      Tester_execTest@chrome://mochikit/content/browser-test.js:1067:9
23:04:22     INFO -      Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:967:9
23:04:22     INFO -      SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
:daisuke Can you please take a look here?
Flags: needinfo?(dakatsuka)
Whiteboard: [stockwell needswork]
Yes, thanks.
Comment on attachment 8963121 [details]
Bug 1447259: Change testing animation since the animation sometimes already finished during waiting for selectNodeAndWaitForAnimations.

https://reviewboard.mozilla.org/r/231996/#review238512

::: commit-message-65d4a:1
(Diff revision 1)
> +Bug 1447259: Change testing animation since the animation sometimes already finished during waiting for selectNodeAndWaitForAnimations. r?gl

Change the tested animation in browser_animation_summary-graph_computed-timing-path_different-timescale.js test since the animation can intermittently already be finished during selectNodeAndWaitForAnimations.
Attachment #8963121 - Flags: review?(gl) → review+
Attachment #8963121 - Attachment is obsolete: true
I will make it to land to the inbound because r+ was cleared after updating a patch.
Flags: needinfo?(dakatsuka)
Pushed by dakatsuka@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/77e268b40ed6
Change the tested animation in browser_animation_summary-graph_computed-timing-path_different-timescale.js test since the animation can intermittently already be finished during selectNodeAndWaitForAnimations. r=gl
Comment on attachment 8964452 [details]
Bug 1447259: Change the tested animation in browser_animation_summary-graph_computed-timing-path_different-timescale.js test since the animation can intermittently already be finished during selectNodeAndWaitForAnimations.

https://reviewboard.mozilla.org/r/233180/#review238662
Attachment #8964452 - Flags: review?(gl) → review+
https://hg.mozilla.org/mozilla-central/rev/77e268b40ed6
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Whiteboard: [stockwell needswork] → [stockwell fixed:other]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: