Closed Bug 1447321 Opened 2 years ago Closed Last year

[wpt-sync] Sync PR 10111 - Move KeyboardLock API methods to a 'keyboard' object

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 10111 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10111
Details from upstream follow.

Joe Downing <joedow@chromium.org> wrote:
>  Move KeyboardLock API methods to a 'keyboard' object
>  
>  This change moves the KeyboardLock API methods to a 'keyboard'
>  namespace on the Navigator object.  We are doing this work now as
>  there has been a request for additional keyboard functionality that
>  would also be placed on the new keyboard object and we wanted to
>  move the KeyboardLock methods there for consistency before we launch.
>  
>  KeyboardLock API Spec is here:
>  https://w3c.github.io/keyboard-lock/#API
>  
>  Old calling pattern:
>  Navigator.keyboardLock();
>  Navigator.leyboardUnlock();
>  
>  New calling pattern:
>  Navigator.keyboard.lock();
>  Navigator.keyboard.unlock();
>  
>  Note: The main logic in the KeyboardLock.cpp class and tests is the
>  same as it was, however the file changed enough that git does not
>  recognize it as a file move.
>  
>  BUG=680809
>  
>  Change-Id: I234b2ab12d5ecd44c894ed5103863fd96fd548d4
>  Reviewed-on: https://chromium-review.googlesource.com/969656
>  WPT-Export-Revision: 5052ff1c647d06530408ad5859debea6790275cd
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Ran 5 tests and 23 subtests
OK     : 5
PASS   : 4
FAIL   : 19

New tests that have failures or other problems:
/keyboard-apis/idlharness.https.html
    Keyboard interface object length: FAIL
    Keyboard interface object name: FAIL
    Keyboard interface: calling lock([object Object]) on navigator.keyboard with too few arguments must throw TypeError: FAIL
    Keyboard interface: existence and properties of interface object: FAIL
    Keyboard interface: existence and properties of interface prototype object: FAIL
    Keyboard interface: existence and properties of interface prototype object's "constructor" property: FAIL
    Keyboard interface: existence and properties of interface prototype object's @@unscopables property: FAIL
    Keyboard interface: navigator.keyboard must inherit property "lock([object Object])" with the proper type: FAIL
    Keyboard interface: navigator.keyboard must inherit property "unlock()" with the proper type: FAIL
    Keyboard interface: operation lock([object Object]): FAIL
    Keyboard interface: operation unlock(): FAIL
    Keyboard must be primary interface of navigator.keyboard: FAIL
    Navigator interface: attribute keyboard: FAIL
    Navigator interface: navigator must inherit property "keyboard" with the proper type: FAIL
    Stringification of navigator.keyboard: FAIL
/keyboard-apis/navigator-keyboard-lock-two-parallel-requests.https.html
    [Keyboard Lock] keyboard.lock twice in parallel: FAIL
/keyboard-apis/navigator-keyboard-lock-two-sequential-requests.https.html
    [Keyboard Lock] keyboard.lock called twice sequentially: FAIL
/keyboard-apis/navigator-keyboard-lock.https.html
    [Keyboard Lock] keyboard.lock: FAIL
/keyboard-apis/navigator-keyboard-unlock.https.html
    [Keyboard Lock] keyboard.unlock: FAIL
P4 is unused to setting priority to P3.
Priority: P4 → P3
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/446e4d678d91
[wpt PR 10111] - Move KeyboardLock API methods to a 'keyboard' object, a=testonly
https://hg.mozilla.org/mozilla-central/rev/446e4d678d91
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.