1447358 - Unifdef the old style system code.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Emilio Cobos Álvarez [:emilio]]

http://dotat.at/prog/unifdef/

Comment 1

[Emilio Cobos Álvarez [:emilio]]

PSA, this will break the MinGW build.

Comment 2

[Phabricator Automation]

Attachment: Bug 1447358: Unifdef the old style system code. r?jwatt

Comment 3

[Tom Ritter [:tjr]]

Filed Bug 1447414 to turn off MinGW.

Comment 4

[Phabricator Automation]

Comment on attachment 8960666 [details]
Bug 1447358: Unifdef the old style system code. r?jwatt

Jonathan Watt [:jwatt] (needinfo? me) has approved the revision.

https://phabricator.services.mozilla.com/D779

Comment 5

[Jonathan Watt [:jwatt]]

This is a good start, but for completeness I'll note that there's a whole lot of code that needs taken out related things like:

StyleBackendType::Gecko
IsStyledByServo
nsStyleContext::IsGecko

Comment 6

[Emilio Cobos Álvarez [:emilio]]

I guess this doesn't really depend on bug 1447414 since it's tier2. I want to land most of the cleanups today so that they don't conflict around (this patch is rather massive), so I don't think it's particularly worth to wait for that.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e5206684eea
Unifdef the old style system code. r=jwatt

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/8e5206684eea