Closed Bug 1447358 Opened 2 years ago Closed 2 years ago

Unifdef the old style system code.

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

PSA, this will break the MinGW build.
Flags: needinfo?(tom)
Flags: needinfo?(gk)
Depends on: 1447367
Filed Bug 1447414 to turn off MinGW.
Flags: needinfo?(tom)
Flags: needinfo?(gk)
Comment on attachment 8960666 [details]
Bug 1447358: Unifdef the old style system code. r?jwatt

Jonathan Watt [:jwatt] (needinfo? me) has approved the revision.

https://phabricator.services.mozilla.com/D779
Attachment #8960666 - Flags: review+
This is a good start, but for completeness I'll note that there's a whole lot of code that needs taken out related things like:

StyleBackendType::Gecko
IsStyledByServo
nsStyleContext::IsGecko
I guess this doesn't really depend on bug 1447414 since it's tier2. I want to land most of the cleanups today so that they don't conflict around (this patch is rather massive), so I don't think it's particularly worth to wait for that.
No longer depends on: 1447414
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e5206684eea
Unifdef the old style system code. r=jwatt
https://hg.mozilla.org/mozilla-central/rev/8e5206684eea
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Depends on: 1447781
You need to log in before you can comment on or make changes to this bug.