Closed
Bug 1447358
Opened 6 years ago
Closed 6 years ago
Unifdef the old style system code.
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
|
Assignee | |
Comment 1•6 years ago
|
||
PSA, this will break the MinGW build.
Flags: needinfo?(tom)
Flags: needinfo?(gk)
|
||
Comment 2•6 years ago
|
||
|
||
Comment 3•6 years ago
|
||
Filed Bug 1447414 to turn off MinGW.
Flags: needinfo?(tom)
Flags: needinfo?(gk)
|
|
||
Comment 4•6 years ago
|
||
Comment on attachment 8960666 [details] Bug 1447358: Unifdef the old style system code. r?jwatt Jonathan Watt [:jwatt] (needinfo? me) has approved the revision. https://phabricator.services.mozilla.com/D779
Attachment #8960666 -
Flags: review+
|
||
Comment 5•6 years ago
|
||
This is a good start, but for completeness I'll note that there's a whole lot of code that needs taken out related things like: StyleBackendType::Gecko IsStyledByServo nsStyleContext::IsGecko
|
|
Assignee | |
Comment 6•6 years ago
|
||
I guess this doesn't really depend on bug 1447414 since it's tier2. I want to land most of the cleanups today so that they don't conflict around (this patch is rather massive), so I don't think it's particularly worth to wait for that.
No longer depends on: 1447414
Pushed by ecoal95@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8e5206684eea Unifdef the old style system code. r=jwatt
|
||
Comment 8•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8e5206684eea
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Depends on: 1493580
You need to log in
before you can comment on or make changes to this bug.
Description
•