Closed Bug 1447367 Opened 2 years ago Closed 2 years ago

Remove files that are not built when MOZ_OLD_STYLE is not defined

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(1 file)

Part of bug 1447358. We should remove files that are not built when MOZ_OLD_STYLE is not defined.
Attached patch patchSplinter Review
We should probably remove --disable-stylo before landing this.
Attachment #8960669 - Flags: review?(emilio)
:jryans, can we remove nsCSSParser? IIRC devtools relied on that somehow, but it'll become dead code now.
Flags: needinfo?(jryans)
Comment on attachment 8960669 [details] [diff] [review]
patch

Review of attachment 8960669 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, as long as we can remove nsCSSParser from the tree.
Attachment #8960669 - Flags: review?(emilio) → review+
(In reply to Emilio Cobos Álvarez [:emilio] from comment #2)
> :jryans, can we remove nsCSSParser? IIRC devtools relied on that somehow,
> but it'll become dead code now.

This should be safe for DevTools.

We do still use `CSSLexer` via `InspectorUtils` (hoping to switch eventually to WASM version of Stylo code instead), but that's not being touched here.
Flags: needinfo?(jryans)
(In reply to Jonathan Watt [:jwatt] from comment #1)
> We should probably remove --disable-stylo before landing this.

Or I guess fixing bug 1447414 is enough.
Depends on: 1447414
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/797722641610
Remove files that are not built when MOZ_OLD_STYLE is not defined. r=emilio
No longer depends on: 1447414
https://hg.mozilla.org/mozilla-central/rev/797722641610
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.