1447392 - Remove all members from nsIDOMNodeList

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Comment 1

[Adrian Wielgosik [:adrian17]]

Attachment: Bug 1447392 - Remove all members from nsIDOMNodeList.

Review commit: https://reviewboard.mozilla.org/r/229450/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229450/

Comment 2

[Adrian Wielgosik [:adrian17]]

Attachment: Bug 1447392 - Remove now-unused overload of nsBindingManager::GetAnonymousNodesFor.

Review commit: https://reviewboard.mozilla.org/r/229452/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229452/

Comment 3

[Adrian Wielgosik [:adrian17]]

Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=74d914e8ea6f3c3bd79f7ac519b297629873b286

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8960761 [details]
Bug 1447392 - Remove all members from nsIDOMNodeList.

https://reviewboard.mozilla.org/r/229450/#review235364

r=me with the nits fixed.

::: dom/base/nsChildContentList.h:41
(Diff revision 1)
> -  NS_DECL_NSIDOMNODELIST
> -
>    // nsINodeList interface
>    virtual int32_t IndexOf(nsIContent* aContent) override;
>    virtual nsIContent* Item(uint32_t aIndex) override;
> +  virtual uint32_t Length() override;

Probably better to follow the style guide and drop the "virtual" here...

::: dom/base/nsChildContentList.h:76
(Diff revision 1)
> -  NS_DECL_NSIDOMNODELIST
> -
>    // nsINodeList interface
>    virtual int32_t IndexOf(nsIContent* aContent) override;
>    virtual nsIContent* Item(uint32_t aIndex) override;
> +  virtual uint32_t Length() override;

And here.

::: dom/base/nsContentList.h:49
(Diff revision 1)
> -
>    // nsINodeList
>    virtual int32_t IndexOf(nsIContent* aContent) override;
>    virtual nsIContent* Item(uint32_t aIndex) override;
>  
> -  uint32_t Length() const {
> +  virtual uint32_t Length() override {

And here.

::: dom/xbl/XBLChildrenElement.h:169
(Diff revision 1)
>  
>    // nsINodeList interface
>    virtual int32_t IndexOf(nsIContent* aContent) override;
>    virtual nsINode* GetParentObject() override { return mParent; }
>    virtual nsIContent* Item(uint32_t aIndex) override;
> +  virtual uint32_t Length() override;

Again, drop the virtual.

::: dom/xbl/XBLChildrenElement.cpp:63
(Diff revision 1)
>    NS_WRAPPERCACHE_INTERFACE_TABLE_ENTRY
>    NS_INTERFACE_TABLE(nsAnonymousContentList, nsINodeList, nsIDOMNodeList)
>    NS_INTERFACE_TABLE_TO_MAP_SEGUE_CYCLE_COLLECTION(nsAnonymousContentList)
>  NS_INTERFACE_MAP_END
>  
> -NS_IMETHODIMP
> +uint32_t nsAnonymousContentList::Length()

Linebreak after type, please.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8960762 [details]
Bug 1447392 - Remove now-unused overload of nsBindingManager::GetAnonymousNodesFor.

https://reviewboard.mozilla.org/r/229452/#review235370

Comment 6

[Adrian Wielgosik [:adrian17]]

Comment on attachment 8960761 [details]
Bug 1447392 - Remove all members from nsIDOMNodeList.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/229450/diff/1-2/

Comment 7

[Adrian Wielgosik [:adrian17]]

Comment on attachment 8960762 [details]
Bug 1447392 - Remove now-unused overload of nsBindingManager::GetAnonymousNodesFor.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/229452/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65c41f6478ab
Remove all members from nsIDOMNodeList. r=bz
https://hg.mozilla.org/integration/autoland/rev/654321c182e9
Remove now-unused overload of nsBindingManager::GetAnonymousNodesFor. r=bz

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/65c41f6478ab
https://hg.mozilla.org/mozilla-central/rev/654321c182e9