Closed Bug 1447392 Opened 7 years ago Closed 7 years ago

Remove all members from nsIDOMNodeList

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: adrian17, Assigned: adrian17)

References

Details

Attachments

(2 files)

No description provided.
Blocks: 1447389
Assignee: nobody → adrian.wielgosik
Status: NEW → ASSIGNED
Comment on attachment 8960761 [details] Bug 1447392 - Remove all members from nsIDOMNodeList. https://reviewboard.mozilla.org/r/229450/#review235364 r=me with the nits fixed. ::: dom/base/nsChildContentList.h:41 (Diff revision 1) > - NS_DECL_NSIDOMNODELIST > - > // nsINodeList interface > virtual int32_t IndexOf(nsIContent* aContent) override; > virtual nsIContent* Item(uint32_t aIndex) override; > + virtual uint32_t Length() override; Probably better to follow the style guide and drop the "virtual" here... ::: dom/base/nsChildContentList.h:76 (Diff revision 1) > - NS_DECL_NSIDOMNODELIST > - > // nsINodeList interface > virtual int32_t IndexOf(nsIContent* aContent) override; > virtual nsIContent* Item(uint32_t aIndex) override; > + virtual uint32_t Length() override; And here. ::: dom/base/nsContentList.h:49 (Diff revision 1) > - > // nsINodeList > virtual int32_t IndexOf(nsIContent* aContent) override; > virtual nsIContent* Item(uint32_t aIndex) override; > > - uint32_t Length() const { > + virtual uint32_t Length() override { And here. ::: dom/xbl/XBLChildrenElement.h:169 (Diff revision 1) > > // nsINodeList interface > virtual int32_t IndexOf(nsIContent* aContent) override; > virtual nsINode* GetParentObject() override { return mParent; } > virtual nsIContent* Item(uint32_t aIndex) override; > + virtual uint32_t Length() override; Again, drop the virtual. ::: dom/xbl/XBLChildrenElement.cpp:63 (Diff revision 1) > NS_WRAPPERCACHE_INTERFACE_TABLE_ENTRY > NS_INTERFACE_TABLE(nsAnonymousContentList, nsINodeList, nsIDOMNodeList) > NS_INTERFACE_TABLE_TO_MAP_SEGUE_CYCLE_COLLECTION(nsAnonymousContentList) > NS_INTERFACE_MAP_END > > -NS_IMETHODIMP > +uint32_t nsAnonymousContentList::Length() Linebreak after type, please.
Attachment #8960761 - Flags: review?(bzbarsky) → review+
Comment on attachment 8960762 [details] Bug 1447392 - Remove now-unused overload of nsBindingManager::GetAnonymousNodesFor. https://reviewboard.mozilla.org/r/229452/#review235370
Attachment #8960762 - Flags: review?(bzbarsky) → review+
Priority: -- → P2
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/65c41f6478ab Remove all members from nsIDOMNodeList. r=bz https://hg.mozilla.org/integration/autoland/rev/654321c182e9 Remove now-unused overload of nsBindingManager::GetAnonymousNodesFor. r=bz
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: