1447454 - Stop allowing implicit downcasts in StrongOrRawPtr

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Boris Zbarsky [:bzbarsky]]

Given the way the StrongOrRawPtr(already_AddRefed<S>&& aPtr) ctor does a downcast, you can do things like:

  interface Foo {
    Element bar();
  };

and then have Foo::bar() return already_AddRefed<nsINode> and this will compile.  This is obviously not good.  ;)

Luckily we have only two things that are relying on this behavior, and both are actually safe.  One is being removed in bug 1446246 and the other is simple to fix.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Stop allowing implicit downcasts in StrongOrRawPtr

Comment 2

[Boris Zbarsky [:bzbarsky]]

Bug 888600 introduced new failures of this sort, but I think bug 1448850 will remove them again....

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5cc5f9c978a3
Stop allowing implicit downcasts in StrongOrRawPtr.  r=peterv

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/5cc5f9c978a3