Closed Bug 1447494 Opened 2 years ago Closed 2 years ago
Stop importing/using gcli test helpers
46 bytes, text/x-phabricator-request
|Details | Review|
This module is referenced in many test related file, whereas it doesn't seem to be used much outside of devtools/client/commandline: https://searchfox.org/mozilla-central/source/devtools/client/commandline/test/helpers.js List of references: https://searchfox.org/mozilla-central/search?q=commandline%2Fhelpers&case=true®exp=false&path= It is used in a couple of places to test gcli commands, but this doesn't justify all these imports at first sight.
Priority: -- → P2
I checked this and it looks like it has been fully removed. :ochameau can you confirm?
I may have removed all the callsites in bug But the helpers file is still referenced by many *.ini files: https://searchfox.org/mozilla-central/search?q=commandline%2Ftest%2Fhelpers&case=true®exp=false&path=devtools It would be interesting to remove them to ensure we really dropped all usages of it. Also, this comment seems to suggest we may be able to get rid of this devtools/client/commandline folder completely! https://searchfox.org/mozilla-central/source/devtools/client/commandline/test/browser.ini#9-13
Removed remaining imports of commandline helpers, as they are no longer used anywhere
You would have to update moz.build file in devtools/client to dereference the one from commandline: https://treeherder.mozilla.org/logviewer.html#?job_id=194095073&repo=try&lineNumber=1122
Comment on attachment 9001242 [details] Bug 1447494 - remove all instances of commandline/helpers; r=ochameau Alexandre Poirot [:ochameau] has approved the revision.
Attachment #9001242 - Flags: review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/7df7135ad04c remove all instances of commandline/helpers; r=ochameau
You need to log in before you can comment on or make changes to this bug.