Stop importing/using gcli test helpers

RESOLVED FIXED in Firefox 63

Status

enhancement
P2
normal
RESOLVED FIXED
a year ago
7 months ago

People

(Reporter: ochameau, Assigned: yulia)

Tracking

unspecified
Firefox 63

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

a year ago
This module is referenced in many test related file, whereas it doesn't seem to be used much outside of devtools/client/commandline:
https://searchfox.org/mozilla-central/source/devtools/client/commandline/test/helpers.js

List of references:
https://searchfox.org/mozilla-central/search?q=commandline%2Fhelpers&case=true&regexp=false&path=

It is used in a couple of places to test gcli commands, but this doesn't justify all these imports at first sight.

Updated

10 months ago
Product: Firefox → DevTools
(Assignee)

Comment 1

9 months ago
I checked this and it looks like it has been fully removed. :ochameau can you confirm?
Flags: needinfo?(poirot.alex)
(Reporter)

Comment 2

8 months ago
I may have removed all the callsites in bug 

But the helpers file is still referenced by many *.ini files:
  https://searchfox.org/mozilla-central/search?q=commandline%2Ftest%2Fhelpers&case=true&regexp=false&path=devtools
It would be interesting to remove them to ensure we really dropped all usages of it.

Also, this comment seems to suggest we may be able to get rid of this devtools/client/commandline folder completely!
  https://searchfox.org/mozilla-central/source/devtools/client/commandline/test/browser.ini#9-13
Flags: needinfo?(poirot.alex)
(Assignee)

Comment 4

8 months ago
Removed remaining imports of commandline helpers, as they are no longer used anywhere
(Reporter)

Comment 5

8 months ago
You would have to update moz.build file in devtools/client to dereference the one from commandline:
  https://treeherder.mozilla.org/logviewer.html#?job_id=194095073&repo=try&lineNumber=1122
(Reporter)

Updated

8 months ago
Assignee: nobody → ystartsev
(Reporter)

Comment 7

8 months ago
Comment on attachment 9001242 [details]
Bug 1447494 - remove all instances of commandline/helpers; r=ochameau

Alexandre Poirot [:ochameau] has approved the revision.
Attachment #9001242 - Flags: review+

Comment 8

8 months ago
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7df7135ad04c
remove all instances of commandline/helpers; r=ochameau

Comment 9

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7df7135ad04c
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63

Updated

7 months ago
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.