Closed
Bug 1447494
Opened 6 years ago
Closed 6 years ago
Stop importing/using gcli test helpers
Categories
(DevTools Graveyard :: Graphic Commandline and Toolbar, enhancement, P2)
DevTools Graveyard
Graphic Commandline and Toolbar
Tracking
(firefox63 fixed)
RESOLVED
FIXED
Firefox 63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: ochameau, Assigned: yulia)
References
Details
Attachments
(1 file)
This module is referenced in many test related file, whereas it doesn't seem to be used much outside of devtools/client/commandline: https://searchfox.org/mozilla-central/source/devtools/client/commandline/test/helpers.js List of references: https://searchfox.org/mozilla-central/search?q=commandline%2Fhelpers&case=true®exp=false&path= It is used in a couple of places to test gcli commands, but this doesn't justify all these imports at first sight.
Priority: -- → P2
Updated•6 years ago
|
Product: Firefox → DevTools
Assignee | ||
Comment 1•6 years ago
|
||
I checked this and it looks like it has been fully removed. :ochameau can you confirm?
Flags: needinfo?(poirot.alex)
Reporter | ||
Comment 2•6 years ago
|
||
I may have removed all the callsites in bug But the helpers file is still referenced by many *.ini files: https://searchfox.org/mozilla-central/search?q=commandline%2Ftest%2Fhelpers&case=true®exp=false&path=devtools It would be interesting to remove them to ensure we really dropped all usages of it. Also, this comment seems to suggest we may be able to get rid of this devtools/client/commandline folder completely! https://searchfox.org/mozilla-central/source/devtools/client/commandline/test/browser.ini#9-13
Flags: needinfo?(poirot.alex)
Assignee | ||
Comment 3•6 years ago
|
||
try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a4c9503f8e033e0ec202ed7feb26272e822ae8b0
Assignee | ||
Comment 4•6 years ago
|
||
Removed remaining imports of commandline helpers, as they are no longer used anywhere
Reporter | ||
Comment 5•6 years ago
|
||
You would have to update moz.build file in devtools/client to dereference the one from commandline: https://treeherder.mozilla.org/logviewer.html#?job_id=194095073&repo=try&lineNumber=1122
Reporter | ||
Updated•6 years ago
|
Assignee: nobody → ystartsev
Assignee | ||
Comment 6•6 years ago
|
||
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=028807c155149e68f7fae2a22198bf8884ec8e25
Reporter | ||
Comment 7•6 years ago
|
||
Comment on attachment 9001242 [details] Bug 1447494 - remove all instances of commandline/helpers; r=ochameau Alexandre Poirot [:ochameau] has approved the revision.
Attachment #9001242 -
Flags: review+
Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7df7135ad04c remove all instances of commandline/helpers; r=ochameau
Comment 9•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7df7135ad04c
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Updated•6 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•