Closed Bug 1447513 Opened 6 years ago Closed 6 years ago
Fix failing TPS test
_history _collision .js
59 bytes, text/x-review-board-request
Currently what's happening is that we're failing to acquire the sync lock when we expect, since logging in triggers a sync. We then fail to sync with the WIPE_REMOTE flag, which means our history entries don't have the right guids, and so the tombstone doesn't get applied. (Note that https://searchfox.org/mozilla-central/source/services/sync/modules/browserid_identity.js#256 also thwarts our attempts to set firstSync somewhat). This all seems rather problematic, but cleaning up TPS's pile of async spaghetti is a problem for another time, especially given it's just a single failure.
Comment on attachment 8960834 [details] Bug 1447513 - Make sure we sync at the start of test_history_collision phase 2 https://reviewboard.mozilla.org/r/229580/#review235334
Attachment #8960834 - Flags: review?(markh) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/fbc30503b744 Make sure we sync at the start of test_history_collision phase 2 r=markh
You need to log in before you can comment on or make changes to this bug.