Closed Bug 1447513 Opened 2 years ago Closed 2 years ago

Fix failing TPS test_history_collision.js

Categories

(Firefox :: Sync, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: tcsc, Assigned: tcsc)

Details

Attachments

(1 file)

Currently what's happening is that we're failing to acquire the sync lock when we expect, since logging in triggers a sync. We then fail to sync with the WIPE_REMOTE flag, which means our history entries don't have the right guids, and so the tombstone doesn't get applied.

(Note that https://searchfox.org/mozilla-central/source/services/sync/modules/browserid_identity.js#256 also thwarts our attempts to set firstSync somewhat).

This all seems rather problematic, but cleaning up TPS's pile of async spaghetti is a problem for another time, especially given it's just a single failure.
Comment on attachment 8960834 [details]
Bug 1447513 - Make sure we sync at the start of test_history_collision phase 2

https://reviewboard.mozilla.org/r/229580/#review235334
Attachment #8960834 - Flags: review?(markh) → review+
Pushed by tchiovoloni@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fbc30503b744
Make sure we sync at the start of test_history_collision phase 2 r=markh
https://hg.mozilla.org/mozilla-central/rev/fbc30503b744
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.