Closed Bug 1447599 Opened 6 years ago Closed 6 years ago

Intermittent devtools/client/inspector/animation/test/browser_animation_keyframes-progress-bar.js | progress bar area should exist -

Categories

(DevTools :: Inspector, defect, P5)

Product:
DevTools
Component:
Inspector
Type:
defect

Tracking

(firefox61 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: daisuke)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 2 obsolete files)

Bug 1447599: Make duration of animations to be longer.
59 bytes, text/x-review-board-request
pbro
: review+
Details 
Filed by: ncsoregi [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=169297303&repo=mozilla-central

https://queue.taskcluster.net/v1/task/EZWCHF33RUyT7ZG9yAayRg/runs/0/artifacts/public/logs/live_backing.log

21:41:22     INFO -  105 INFO TEST-PASS | devtools/client/inspector/animation/test/browser_animation_keyframes-progress-bar.js | Position should apploximately be 0 (x of bar is 0) -
21:41:22     INFO -  106 INFO Scrubber position is 0.33
21:41:22     INFO -  107 INFO Click 46.2 on scrubber controller
21:41:22     INFO -  Buffered messages logged at 21:41:20
21:41:22     INFO -  108 INFO TEST-PASS | devtools/client/inspector/animation/test/browser_animation_keyframes-progress-bar.js | Position should apploximately be 0 (x of bar is 0) -
21:41:22     INFO -  109 INFO Scrubber position is 0.5
21:41:22     INFO -  110 INFO Click 70 on scrubber controller
21:41:22     INFO -  Buffered messages logged at 21:41:21
21:41:22     INFO -  111 INFO TEST-PASS | devtools/client/inspector/animation/test/browser_animation_keyframes-progress-bar.js | Position should apploximately be 35 (x of bar is 35) -
21:41:22     INFO -  112 INFO Checking progress bar position for delay-negative
21:41:22     INFO -  113 INFO Selecting the node for '.delay-negative'
21:41:22     INFO -  Buffered messages logged at 21:41:22
21:41:22     INFO -  114 INFO Checking progress bar existence
21:41:22     INFO -  Buffered messages finished
21:41:22    ERROR -  115 INFO TEST-UNEXPECTED-FAIL | devtools/client/inspector/animation/test/browser_animation_keyframes-progress-bar.js | progress bar area should exist -
21:41:22     INFO -  Stack trace:
21:41:22     INFO -  chrome://mochitests/content/browser/devtools/client/inspector/animation/test/browser_animation_keyframes-progress-bar.js:null:68
21:41:22     INFO -  Not taking screenshot here: see the one that was previously logged
21:41:22    ERROR -  116 INFO TEST-UNEXPECTED-FAIL | devtools/client/inspector/animation/test/browser_animation_keyframes-progress-bar.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/inspector/animation/test/browser_animation_keyframes-progress-bar.js:69 - TypeError: areaEl is null
21:41:22     INFO -  Stack trace:
21:41:22     INFO -      @chrome://mochitests/content/browser/devtools/client/inspector/animation/test/browser_animation_keyframes-progress-bar.js:69:11
21:41:22     INFO -      Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1079:21
21:41:22     INFO -      Tester_execTest@chrome://mochikit/content/browser-test.js:1070:9
21:41:22     INFO -      Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:970:9
21:41:22     INFO -      SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
21:41:22     INFO -  117 INFO Leaving test bound
21:41:22     INFO -  GECKO(3368) | ++DOMWINDOW == 21 (00000255175C4C00) [pid = 3368] [serial = 204] [outer = 00000255175BC000]
21:41:22     INFO -  GECKO(3368) | --DOCSHELL 000002551B35F800 == 7 [pid = 3368] [id = {6dacc88b-3d3e-4035-8d9c-14fcb2d83dac}]
21:41:22     INFO -  GECKO(3368) | --DOCSHELL 000002551BB15000 == 6 [pid = 3368] [id = {0a569b0d-71ea-4cd7-bbf7-acff0ac0b8ca}]
21:41:22     INFO -  GECKO(3368) | --DOCSHELL 000002551E68E800 == 5 [pid = 3368] [id = {5f32bd18-258b-47fc-bfa6-c1cab1de57be}]
21:41:22     INFO -  118 INFO Removing tab.
21:41:22     INFO -  119 INFO Waiting for event: 'TabClose' on [object XULElement].
21:41:22     INFO -  120 INFO Got event: 'TabClose' on [object XULElement].
21:41:22     INFO -  121 INFO Tab removed and finished closing
21:41:23     INFO -  GECKO(3368) | MEMORY STAT | vsize 2357MB | vsizeMaxContiguous 131733656MB | residentFast 461MB | heapAllocated 148MB
21:41:23     INFO -  122 INFO TEST-OK | devtools/client/inspector/animation/test/browser_animation_keyframes-progress-bar.js | took 81060ms
Assignee: nobody → dakatsuka
See Also: → 1447500
The reason why expand the duration is that some animations has negative delay/endDelay. This will reduce the animated time, then NoAnimationPanel will display. Therefor, we can't get the area element.

This will fix bug 1447500 too.
Comment on attachment 8961624 [details]
Bug 1447599: Make duration of animations to be longer.

https://reviewboard.mozilla.org/r/230494/#review235978
Attachment #8961624 - Flags: review?(gl) → review?(pbrosset)
Comment on attachment 8961624 [details]
Bug 1447599: Make duration of animations to be longer.

Sorry, please let me cancel this review since the try has some errors.
Attachment #8961624 - Flags: review?(pbrosset)
Attachment #8961624 - Attachment is obsolete: true
Comment on attachment 8961769 [details]
Bug 1447599: Make duration of animations to be longer.

https://reviewboard.mozilla.org/r/230614/#review236118

Looks good overall, just one comment that I'd like your opinion on before providing r+

::: devtools/client/inspector/animation/test/browser_animation_keyframes-progress-bar.js:12
(Diff revision 1)
>  // * element existence
>  // * progress bar position in multi effect timings
>  // * progress bar position after changing playback rate
>  // * progress bar position when select another animation
>  
> +requestLongerTimeout(5);

Wow, 5! We didn't have any requestLongerTimeout before, wouldn't it be better to start with a value of 2 first? And then increase if needed.
Can this test be splitted you think?
Having tests this long isn't great.
Attachment #8961769 - Flags: review?(pbrosset)
Thank you very much for your quick review!

Yeah, but I checked previous try as well, sometimes this test was taking about 3min in windows10-64-ccov. Then, I decided 5 (means 45sec x 5 = 225sec = 3min 45sec)
Or, is it better to split somehow?
(In reply to Daisuke Akatsuka (:daisuke) from comment #10)
> Or, is it better to split somehow?
Yes, if we can. Some tests aren't easily splitable. But if there's a way to do so, it would be better.
Maybe we can also make it faster?
If it's hard work to do any of this, feel free to re-request review as is and file a follow-up bug to do the rest.
Thanks.
Yeah, I also had been re-thinking reducing the taking time for all tests as much as possible.
I'll file a bug for the issue. And thanks, will re-request review as it is.
Attachment #8961769 - Attachment is obsolete: true
Filed bug 1448732.
Comment on attachment 8962227 [details]
Bug 1447599: Make duration of animations to be longer.

https://reviewboard.mozilla.org/r/231068/#review236526
Attachment #8962227 - Flags: review?(pbrosset) → review+
Pushed by dakatsuka@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/48f500bd2d81
Make duration of animations to be longer. r=pbro
https://hg.mozilla.org/mozilla-central/rev/48f500bd2d81
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: