Closed
Bug 1447621
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 10122 - [css-grid] Fix testing-utils.js
Categories
(Core :: CSS Parsing and Computation, enhancement, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 10122 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/w3c/web-platform-tests/pull/10122 Details from upstream follow. Manuel Rego Casasnovas <rego@igalia.com> wrote: > [css-grid] Fix testing-utils.js > > We have been calling testGridTemplateColumnsRows() with > and without arrays. > Arrays are needed because the serialization of 2 tracks of the same size > can be "100px 100px" or "repeat(2, 100px)". > But in the rest of the cases we don't need an array, > so we call the method with a single value. > testGridTemplateColumnsRows() was not ready to support that, > and it wasn't actually checking anything in that case. > > The patch modifies testing-utils.js, so it wraps values in an array > when required. > Now testGridTemplateColumnsRows() will be actually checking things. > > Change-Id: I7e360677c391df74dedb474922bf5c04247141c5 > > Reviewed-on: https://chromium-review.googlesource.com/973063 > WPT-Export-Revision: e8d18aee2d1581246e0e2ba13925546d51d434ca
Reporter | ||
Updated•6 years ago
|
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Reporter | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7b428782bef870cf81e5b0b1c73735e021e575c
Reporter | ||
Comment 2•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=291abc9c93a695115e2538cf7b914f479e93750e
Reporter | ||
Comment 3•6 years ago
|
||
Ran 12 tests and 618 subtests OK : 12 PASS : 588 FAIL : 30
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/939bbbe07477 [wpt PR 10122] - [css-grid] Fix testing-utils.js, a=testonly
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/939bbbe07477
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/939bbbe07477
You need to log in
before you can comment on or make changes to this bug.
Description
•